* [sailus-media-tree:frame-desc 13/17] drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c:109:25: warning: format '%d' expects argument of type 'int', but argument 5 has type 'long int'
@ 2026-05-15 3:05 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-05-15 3:05 UTC (permalink / raw)
To: Sakari Ailus; +Cc: oe-kbuild-all, linux-media
tree: git://linuxtv.org/sailus/media_tree.git frame-desc
head: a0e9f7cf4fcd819e3c994fd629a63789748d81c5
commit: 0cf56292ac3200bd6a515db66aa9ed69fa60b091 [13/17] media: rkisp1: Use v4l2_subdev_get_frame_desc()
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20260515/202605151137.DEgSW7Zb-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260515/202605151137.DEgSW7Zb-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605151137.DEgSW7Zb-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/pm_runtime.h:11,
from drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c:13:
drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c: In function 'rkisp1_gasket_enable':
>> drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c:109:25: warning: format '%d' expects argument of type 'int', but argument 5 has type 'long int' [-Wformat=]
109 | "failed to get frame descriptor from '%s':%u: %d\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c:108:17: note: in expansion of macro 'dev_err'
108 | dev_err(rkisp1->dev,
| ^~~~~~~
drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c:109:72: note: format string is defined here
109 | "failed to get frame descriptor from '%s':%u: %d\n",
| ~^
| |
| int
| %ld
vim +109 drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 86
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 87 static int rkisp1_gasket_enable(struct rkisp1_device *rkisp1,
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 88 struct media_pad *source)
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 89 {
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 90 struct v4l2_subdev *source_sd;
0cf56292ac3200 Sakari Ailus 2026-05-12 91 struct v4l2_mbus_frame_desc *fd __free(v4l2_subdev_free_frame_desc) =
0cf56292ac3200 Sakari Ailus 2026-05-12 92 NULL;
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 93 unsigned int dt;
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 94 u32 mask;
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 95 u32 val;
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 96
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 97 /*
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 98 * Configure and enable the gasket with the CSI-2 data type. Set the
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 99 * vsync polarity as active high, as that is what the ISP is configured
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 100 * to expect in ISP_ACQ_PROP. Enable left justification, as the i.MX8MP
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 101 * ISP has a 16-bit wide input and expects data to be left-aligned.
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 102 */
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 103
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 104 source_sd = media_entity_to_v4l2_subdev(source->entity);
0cf56292ac3200 Sakari Ailus 2026-05-12 105 fd = v4l2_subdev_get_frame_desc(source_sd, source->index,
0cf56292ac3200 Sakari Ailus 2026-05-12 106 V4L2_MBUS_FRAME_DESC_TYPE_CSI2);
0cf56292ac3200 Sakari Ailus 2026-05-12 107 if (IS_ERR(fd)) {
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 108 dev_err(rkisp1->dev,
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 @109 "failed to get frame descriptor from '%s':%u: %d\n",
0cf56292ac3200 Sakari Ailus 2026-05-12 110 source_sd->name, 0, PTR_ERR(fd));
0cf56292ac3200 Sakari Ailus 2026-05-12 111 return PTR_ERR(fd);
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 112 }
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 113
0cf56292ac3200 Sakari Ailus 2026-05-12 114 if (fd->num_entries != 1) {
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 115 dev_err(rkisp1->dev, "invalid frame descriptor for '%s':%u\n",
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 116 source_sd->name, 0);
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 117 return -EINVAL;
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 118 }
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 119
0cf56292ac3200 Sakari Ailus 2026-05-12 120 dt = fd->entry[0].bus.csi2.dt;
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 121
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 122 if (rkisp1->gasket_id == 0) {
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 123 mask = ISP_DEWARP_CONTROL_MIPI_CSI1_HS_POLARITY
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 124 | ISP_DEWARP_CONTROL_MIPI_CSI1_VS_SEL_MASK
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 125 | ISP_DEWARP_CONTROL_MIPI_ISP1_LEFT_JUST_MODE
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 126 | ISP_DEWARP_CONTROL_MIPI_ISP1_DATA_TYPE_MASK
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 127 | ISP_DEWARP_CONTROL_GPR_ISP_0_DISABLE;
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 128 val = ISP_DEWARP_CONTROL_MIPI_CSI1_VS_SEL_POSITIVE
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 129 | ISP_DEWARP_CONTROL_MIPI_ISP1_LEFT_JUST_MODE
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 130 | ISP_DEWARP_CONTROL_MIPI_ISP1_DATA_TYPE(dt);
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 131 } else {
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 132 mask = ISP_DEWARP_CONTROL_MIPI_CSI2_HS_POLARITY
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 133 | ISP_DEWARP_CONTROL_MIPI_CSI2_VS_SEL_MASK
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 134 | ISP_DEWARP_CONTROL_MIPI_ISP2_LEFT_JUST_MODE
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 135 | ISP_DEWARP_CONTROL_MIPI_ISP2_DATA_TYPE_MASK
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 136 | ISP_DEWARP_CONTROL_GPR_ISP_1_DISABLE;
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 137 val = ISP_DEWARP_CONTROL_MIPI_CSI2_VS_SEL_POSITIVE
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 138 | ISP_DEWARP_CONTROL_MIPI_ISP2_LEFT_JUST_MODE
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 139 | ISP_DEWARP_CONTROL_MIPI_ISP2_DATA_TYPE(dt);
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 140 }
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 141
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 142 regmap_update_bits(rkisp1->gasket, ISP_DEWARP_CONTROL, mask, val);
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 143
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 144 return 0;
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 145 }
fdac4ce9f4fd21 Laurent Pinchart 2024-02-16 146
:::::: The code at line 109 was first introduced by commit
:::::: fdac4ce9f4fd2120b439d29607f922665ffe31f6 media: rkisp1: Configure gasket on i.MX8MP
:::::: TO: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
:::::: CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-05-15 3:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-15 3:05 [sailus-media-tree:frame-desc 13/17] drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c:109:25: warning: format '%d' expects argument of type 'int', but argument 5 has type 'long int' kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox