* [PATCH v2] media: v4l2-core: Fix memory leak in v4l2_fwnode_parse_link
@ 2026-06-19 8:11 Biren Pandya
0 siblings, 0 replies; only message in thread
From: Biren Pandya @ 2026-06-19 8:11 UTC (permalink / raw)
To: sakari.ailus, laurent.pinchart, mchehab
Cc: linux-media, linux-kernel, Biren Pandya
In v4l2_fwnode_parse_link(), the remote endpoint fwnode reference is
acquired using fwnode_graph_get_remote_endpoint(). This reference is
properly released in the error paths, but it is leaked on the success
path.
Add the missing fwnode_handle_put() before returning 0 to prevent the
reference leak.
Signed-off-by: Biren Pandya <birenpandya@gmail.com>
---
Changes in v2:
- Resend because the v1 patch was lost in transit and did not appear on lore.kernel.org, causing CI to fail looking for the message ID. No code changes.
drivers/media/v4l2-core/v4l2-fwnode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c
index 77f3298821b5..93ef83c591ef 100644
--- a/drivers/media/v4l2-core/v4l2-fwnode.c
+++ b/drivers/media/v4l2-core/v4l2-fwnode.c
@@ -633,6 +633,7 @@ int v4l2_fwnode_parse_link(struct fwnode_handle *fwnode,
if (!link->remote_node)
goto err_put_remote_endpoint;
+ fwnode_handle_put(fwnode);
return 0;
err_put_remote_endpoint:
--
2.50.1 (Apple Git-155)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-06-19 8:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-19 8:11 [PATCH v2] media: v4l2-core: Fix memory leak in v4l2_fwnode_parse_link Biren Pandya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox