Linux Media Controller development
 help / color / mirror / Atom feed
From: Biren Pandya <birenpandya@gmail.com>
To: linux-media@vger.kernel.org
Cc: "Biren Pandya" <birenpandya@gmail.com>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>
Subject: [PATCH 1/4] media: renesas: rcar-csi2: Add missing media_entity_cleanup()
Date: Fri, 19 Jun 2026 15:52:43 +0530	[thread overview]
Message-ID: <20260619102241.22887-7-birenpandya@gmail.com> (raw)
In-Reply-To: <20260619102241.22887-6-birenpandya@gmail.com>

The probe error paths and remove function are missing calls to
media_entity_cleanup(). Add them and introduce an err_entity label
to ensure teardown logic properly inverses initialization.

Signed-off-by: Biren Pandya <birenpandya@gmail.com>
---
 drivers/media/platform/renesas/rcar-csi2.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/renesas/rcar-csi2.c b/drivers/media/platform/renesas/rcar-csi2.c
index 7305cc4a04cb..9720e0cbd1db 100644
--- a/drivers/media/platform/renesas/rcar-csi2.c
+++ b/drivers/media/platform/renesas/rcar-csi2.c
@@ -2617,7 +2617,7 @@ static int rcsi2_probe(struct platform_device *pdev)
 
 	ret = v4l2_subdev_init_finalize(&priv->subdev);
 	if (ret)
-		goto error_pm_runtime;
+		goto error_entity;
 
 	ret = v4l2_async_register_subdev(&priv->subdev);
 	if (ret < 0)
@@ -2631,6 +2631,8 @@ static int rcsi2_probe(struct platform_device *pdev)
 	v4l2_subdev_cleanup(&priv->subdev);
 error_pm_runtime:
 	pm_runtime_disable(&pdev->dev);
+error_entity:
+	media_entity_cleanup(&priv->subdev.entity);
 error_async:
 	v4l2_async_nf_unregister(&priv->notifier);
 	v4l2_async_nf_cleanup(&priv->notifier);
@@ -2646,6 +2648,7 @@ static void rcsi2_remove(struct platform_device *pdev)
 	v4l2_async_nf_cleanup(&priv->notifier);
 	v4l2_async_unregister_subdev(&priv->subdev);
 	v4l2_subdev_cleanup(&priv->subdev);
+	media_entity_cleanup(&priv->subdev.entity);
 
 	pm_runtime_disable(&pdev->dev);
 }
-- 
2.50.1 (Apple Git-155)


  reply	other threads:[~2026-06-19 10:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19 10:22 [PATCH 0/4] media: renesas: Add missing media_entity_cleanup() calls Biren Pandya
2026-06-19 10:22 ` Biren Pandya [this message]
2026-06-19 10:22 ` [PATCH 2/4] media: renesas: csisp: Add missing media_entity_cleanup() Biren Pandya
2026-06-19 10:22 ` [PATCH 3/4] media: renesas: rcar-core: " Biren Pandya
2026-06-19 10:22 ` [PATCH 4/4] media: renesas: rzg2l-core: " Biren Pandya
2026-06-19 12:17 ` [PATCH v2 1/4] media: renesas: rcar-csi2: " Biren Pandya
2026-06-19 12:17   ` [PATCH v2 2/4] media: renesas: csisp: " Biren Pandya
2026-06-19 12:17   ` [PATCH v2 3/4] media: renesas: rcar-core: " Biren Pandya
2026-06-19 12:17   ` [PATCH v2 4/4] media: renesas: rzg2l-core: " Biren Pandya
2026-06-22  8:06   ` [PATCH v2 1/4] media: renesas: rcar-csi2: " Jacopo Mondi
2026-06-22 11:57     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260619102241.22887-7-birenpandya@gmail.com \
    --to=birenpandya@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-media@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=niklas.soderlund@ragnatech.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox