Re: [PATCH v2 1/4] media: renesas: rcar-csi2: Add missing media_entity_cleanup()

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Mon, Jun 22, 2026 at 10:06:54AM +0200, Jacopo Mondi wrote:
> Hi Biren
> 
> On Fri, Jun 19, 2026 at 05:47:30PM +0530, Biren Pandya wrote:
> > The probe error paths and remove function are missing calls to
> > media_entity_cleanup(). Add them and introduce an err_entity label
> > to ensure teardown logic properly inverses initialization.
> >
> > Signed-off-by: Biren Pandya <birenpandya@gmail.com>
> 
> Have you at least compiled this patch ?
> 
> ../drivers/media/platform/renesas/rcar-csi2.c: In function ‘rcsi2_probe’:
> ../drivers/media/platform/renesas/rcar-csi2.c:2634:1: error: label ‘error_entity’ defined but not used [-Werror=unused-label]
>  2634 | error_entity:
>       | ^~~~~~~~~~~~
> 
> Also, don't send v(n+1) in reply to v(n). Each version of a series
> goes in its own thread, with a proper cover letter and changelog.
> 
> I suggest to use b4.

Also, while it's OK to not send all patches of a series to everybody,
the cover letter must be send to all recipients.

> > ---
> >  drivers/media/platform/renesas/rcar-csi2.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/media/platform/renesas/rcar-csi2.c b/drivers/media/platform/renesas/rcar-csi2.c
> > index 7305cc4a04cb..61d7dfe14688 100644
> > --- a/drivers/media/platform/renesas/rcar-csi2.c
> > +++ b/drivers/media/platform/renesas/rcar-csi2.c
> > @@ -2631,6 +2631,8 @@ static int rcsi2_probe(struct platform_device *pdev)
> >  	v4l2_subdev_cleanup(&priv->subdev);
> >  error_pm_runtime:
> >  	pm_runtime_disable(&pdev->dev);
> > +error_entity:
> > +	media_entity_cleanup(&priv->subdev.entity);
> >  error_async:
> >  	v4l2_async_nf_unregister(&priv->notifier);
> >  	v4l2_async_nf_cleanup(&priv->notifier);
> > @@ -2646,6 +2648,7 @@ static void rcsi2_remove(struct platform_device *pdev)
> >  	v4l2_async_nf_cleanup(&priv->notifier);
> >  	v4l2_async_unregister_subdev(&priv->subdev);
> >  	v4l2_subdev_cleanup(&priv->subdev);
> > +	media_entity_cleanup(&priv->subdev.entity);
> >
> >  	pm_runtime_disable(&pdev->dev);
> >  }

-- 
Regards,

Laurent Pinchart