From: Vladimir Zapolskiy <vz@kernel.org>
To: Hans de Goede <hansg@kernel.org>
Cc: Bryan O'Donoghue <bod@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only
Date: Sun, 21 Jun 2026 17:58:08 +0300 [thread overview]
Message-ID: <20260621145808.2660219-1-vz@kernel.org> (raw)
Originally a chip id check in the driver's probe function is done for
any OmniVision "ov02" sensors, but is too wide, since there are at least
"ov02a", "ov02b", "ov02c", "ov02e", "ov02g", "ov02k" and likely even
more families of sensors with similar names, thus the check for id shall
be more specific and match "ov02c" exclusively and expectedly.
Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
---
drivers/media/i2c/ov02c10.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
index cf93d36032e1..b36da75d7dfa 100644
--- a/drivers/media/i2c/ov02c10.c
+++ b/drivers/media/i2c/ov02c10.c
@@ -18,8 +18,8 @@
#define OV02C10_MCLK 19200000
#define OV02C10_RGB_DEPTH 10
-#define OV02C10_REG_CHIP_ID CCI_REG16(0x300a)
-#define OV02C10_CHIP_ID 0x5602
+#define OV02C10_REG_CHIP_ID CCI_REG24(0x300a)
+#define OV02C10_CHIP_ID 0x560243
#define OV02C10_REG_STREAM_CONTROL CCI_REG8(0x0100)
--
2.51.0
reply other threads:[~2026-06-21 14:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260621145808.2660219-1-vz@kernel.org \
--to=vz@kernel.org \
--cc=bod@kernel.org \
--cc=hansg@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox