* [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only
@ 2026-06-21 14:58 Vladimir Zapolskiy
2026-06-22 6:00 ` Tarang Raval
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Zapolskiy @ 2026-06-21 14:58 UTC (permalink / raw)
To: Hans de Goede
Cc: Bryan O'Donoghue, Sakari Ailus, Mauro Carvalho Chehab,
linux-media
Originally a chip id check in the driver's probe function is done for
any OmniVision "ov02" sensors, but is too wide, since there are at least
"ov02a", "ov02b", "ov02c", "ov02e", "ov02g", "ov02k" and likely even
more families of sensors with similar names, thus the check for id shall
be more specific and match "ov02c" exclusively and expectedly.
Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
---
drivers/media/i2c/ov02c10.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
index cf93d36032e1..b36da75d7dfa 100644
--- a/drivers/media/i2c/ov02c10.c
+++ b/drivers/media/i2c/ov02c10.c
@@ -18,8 +18,8 @@
#define OV02C10_MCLK 19200000
#define OV02C10_RGB_DEPTH 10
-#define OV02C10_REG_CHIP_ID CCI_REG16(0x300a)
-#define OV02C10_CHIP_ID 0x5602
+#define OV02C10_REG_CHIP_ID CCI_REG24(0x300a)
+#define OV02C10_CHIP_ID 0x560243
#define OV02C10_REG_STREAM_CONTROL CCI_REG8(0x0100)
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only
2026-06-21 14:58 [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only Vladimir Zapolskiy
@ 2026-06-22 6:00 ` Tarang Raval
0 siblings, 0 replies; 2+ messages in thread
From: Tarang Raval @ 2026-06-22 6:00 UTC (permalink / raw)
To: Vladimir Zapolskiy, Hans de Goede
Cc: Bryan O'Donoghue, Sakari Ailus, Mauro Carvalho Chehab,
linux-media@vger.kernel.org
Hi Vladimir,
> Originally a chip id check in the driver's probe function is done for
> any OmniVision "ov02" sensors, but is too wide, since there are at least
> "ov02a", "ov02b", "ov02c", "ov02e", "ov02g", "ov02k" and likely even
> more families of sensors with similar names, thus the check for id shall
> be more specific and match "ov02c" exclusively and expectedly.
>
> Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
> ---
> drivers/media/i2c/ov02c10.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
> index cf93d36032e1..b36da75d7dfa 100644
> --- a/drivers/media/i2c/ov02c10.c
> +++ b/drivers/media/i2c/ov02c10.c
> @@ -18,8 +18,8 @@
> #define OV02C10_MCLK 19200000
> #define OV02C10_RGB_DEPTH 10
>
> -#define OV02C10_REG_CHIP_ID CCI_REG16(0x300a)
> -#define OV02C10_CHIP_ID 0x5602
> +#define OV02C10_REG_CHIP_ID CCI_REG24(0x300a)
> +#define OV02C10_CHIP_ID 0x560243
Reviewed-by: Tarang Raval <tarang.raval@siliconsignals.io>
Best Regards,
Tarang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-22 6:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-21 14:58 [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only Vladimir Zapolskiy
2026-06-22 6:00 ` Tarang Raval
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox