* [PATCH] dma-buf/dma-fence: Set better string for dma_fence_driver_name()
@ 2026-06-23 13:34 Philipp Stanner
2026-06-23 14:00 ` Tvrtko Ursulin
0 siblings, 1 reply; 2+ messages in thread
From: Philipp Stanner @ 2026-06-23 13:34 UTC (permalink / raw)
To: Sumit Semwal, Christian König, Tvrtko Ursulin
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel,
Philipp Stanner
dma_fence_driver_name() reports that a driver whose fence is already
signaled is a "detached-driver". This is incorrect, the driver might
still be loaded and running.
Rename that string to something more descriptive.
Signed-off-by: Philipp Stanner <phasta@kernel.org>
---
Just compile-tested.
---
drivers/dma-buf/dma-fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
index c7ea1e75d38a..9c3dfa7b0066 100644
--- a/drivers/dma-buf/dma-fence.c
+++ b/drivers/dma-buf/dma-fence.c
@@ -1173,7 +1173,7 @@ const char __rcu *dma_fence_driver_name(struct dma_fence *fence)
if (!dma_fence_test_signaled_flag(fence))
return (const char __rcu *)ops->get_driver_name(fence);
else
- return (const char __rcu *)"detached-driver";
+ return (const char __rcu *)"driver-whose-fence-is-signaled";
}
EXPORT_SYMBOL(dma_fence_driver_name);
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dma-buf/dma-fence: Set better string for dma_fence_driver_name()
2026-06-23 13:34 [PATCH] dma-buf/dma-fence: Set better string for dma_fence_driver_name() Philipp Stanner
@ 2026-06-23 14:00 ` Tvrtko Ursulin
0 siblings, 0 replies; 2+ messages in thread
From: Tvrtko Ursulin @ 2026-06-23 14:00 UTC (permalink / raw)
To: Philipp Stanner, Sumit Semwal, Christian König,
Tvrtko Ursulin
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel
On 23/06/2026 14:34, Philipp Stanner wrote:
> dma_fence_driver_name() reports that a driver whose fence is already
> signaled is a "detached-driver". This is incorrect, the driver might
> still be loaded and running.
>
> Rename that string to something more descriptive.
>
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
> ---
> Just compile-tested.
> ---
> drivers/dma-buf/dma-fence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index c7ea1e75d38a..9c3dfa7b0066 100644
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -1173,7 +1173,7 @@ const char __rcu *dma_fence_driver_name(struct dma_fence *fence)
> if (!dma_fence_test_signaled_flag(fence))
> return (const char __rcu *)ops->get_driver_name(fence);
> else
> - return (const char __rcu *)"detached-driver";
> + return (const char __rcu *)"driver-whose-fence-is-signaled";
My logic was "driver detached from the fence". :)
Anyway, no strong opinion apart to be mindful on whether some output
becomes overly verbose.
Regards,
Tvrtko
> }
> EXPORT_SYMBOL(dma_fence_driver_name);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-23 14:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-23 13:34 [PATCH] dma-buf/dma-fence: Set better string for dma_fence_driver_name() Philipp Stanner
2026-06-23 14:00 ` Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox