* [PATCH v4] media: atomisp: fix block comment formatting style
@ 2026-07-01 16:14 Bohdan D. Marcus
2026-07-02 9:12 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Bohdan D. Marcus @ 2026-07-01 16:14 UTC (permalink / raw)
To: error27, gregkh, hansg, mchehab
Cc: andy, sakari.ailus, linux-media, linux-staging, linux-kernel,
Bohdan D. Marcus
Fix a block comment formatting warning reported by
checkpatch.pl in atomisp_cmd.c to conform to the
Linux kernel coding style.
Signed-off-by: Bohdan D. Marcus <bohdandmarcus@gmail.com>
---
Changes in v4:
- Fixed code indentation (removed excessive tabs) as requested by Dan Carpenter
Changes in v3:
- Fixed commit description line wrap to be under 75 chars per line
Changes in v2:
- Fixed author name and Signed-off-by email mismatch
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 6cd500d9fd26..d4c823f18cab 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -2520,9 +2520,12 @@ int atomisp_css_cp_dvs2_coefs(struct atomisp_sub_device *asd,
if (sizeof(*cur) != sizeof(dvs2_coefs.grid) ||
memcmp(&dvs2_coefs.grid, cur, sizeof(dvs2_coefs.grid))) {
dev_err(asd->isp->dev, "dvs grid mismatch!\n");
- /* If the grid info in the argument differs from the current
- grid info, we tell the caller to reset the grid size and
- try again. */
+ /*
+ * If the grid info in the argument differs
+ * from the current grid info, we tell the
+ * caller to reset the grid size and try
+ * again.
+ */
return -EAGAIN;
}
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v4] media: atomisp: fix block comment formatting style
2026-07-01 16:14 [PATCH v4] media: atomisp: fix block comment formatting style Bohdan D. Marcus
@ 2026-07-02 9:12 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-07-02 9:12 UTC (permalink / raw)
To: Bohdan D. Marcus
Cc: error27, gregkh, hansg, mchehab, andy, sakari.ailus, linux-media,
linux-staging, linux-kernel
On Wed, Jul 01, 2026 at 07:14:51PM +0300, Bohdan D. Marcus wrote:
> Fix a block comment formatting warning reported by
> checkpatch.pl in atomisp_cmd.c to conform to the
> Linux kernel coding style.
This is too condensed commit message, use up to ~72 characters per line.
Also try to find more issues of the kind and fix them altogether.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-02 9:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-01 16:14 [PATCH v4] media: atomisp: fix block comment formatting style Bohdan D. Marcus
2026-07-02 9:12 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox