From: Brandon Brnich <b-brnich@ti.com>
To: <devarsht@ti.com>, <mchehab@kernel.org>, <hverkuil@kernel.org>,
<sebastian.fricke@collabora.com>,
<benjamin.gaignard@collabora.com>, <linux-media@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: Brandon Brnich <b-brnich@ti.com>, <stable@vger.kernel.org>
Subject: [PATCH v4 1/4] media: imagination: e5010: Properly Release m2m_dev if probe fails
Date: Mon, 31 Aug 2026 16:32:28 -0500 [thread overview]
Message-ID: <20260831213231.2125544-2-b-brnich@ti.com> (raw)
In-Reply-To: <20260831213231.2125544-1-b-brnich@ti.com>
After the call to v4l2_m2m_init() is successful, the following
initialization functions should go to fail_after_video_register_device.
Fixes: a1e294045885 ("media: imagination: Add E5010 JPEG Encoder driver")
Cc: stable@vger.kernel.org
Signed-off-by: Brandon Brnich <b-brnich@ti.com>
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/media/platform/imagination/e5010-jpeg-enc.c
index 42ad9ee3993b4..d3c11337c815d 100644
--- a/drivers/media/platform/imagination/e5010-jpeg-enc.c
+++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c
@@ -1072,14 +1072,14 @@ static int e5010_probe(struct platform_device *pdev)
if (IS_ERR(e5010->core_base)) {
ret = PTR_ERR(e5010->core_base);
dev_err_probe(dev, ret, "Missing 'core' resources area\n");
- goto fail_after_v4l2_register;
+ goto fail_after_video_register_device;
}
e5010->mmu_base = devm_platform_ioremap_resource_byname(pdev, "mmu");
if (IS_ERR(e5010->mmu_base)) {
ret = PTR_ERR(e5010->mmu_base);
dev_err_probe(dev, ret, "Missing 'mmu' resources area\n");
- goto fail_after_v4l2_register;
+ goto fail_after_video_register_device;
}
e5010->last_context_run = NULL;
@@ -1089,14 +1089,14 @@ static int e5010_probe(struct platform_device *pdev)
E5010_MODULE_NAME, e5010);
if (ret) {
dev_err_probe(dev, ret, "failed to register IRQ %d\n", irq);
- goto fail_after_v4l2_register;
+ goto fail_after_video_register_device;
}
e5010->clk = devm_clk_get(dev, NULL);
if (IS_ERR(e5010->clk)) {
ret = PTR_ERR(e5010->clk);
dev_err_probe(dev, ret, "failed to get clock\n");
- goto fail_after_v4l2_register;
+ goto fail_after_video_register_device;
}
pm_runtime_enable(dev);
--
2.43.0
next prev parent reply other threads:[~2026-08-31 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 21:32 [PATCH v4 0/4] E5010 Probe Cleanup and Adding autosuspend Brandon Brnich
2026-08-31 21:32 ` Brandon Brnich [this message]
2026-08-31 21:32 ` [PATCH v4 2/4] media: imagination: e5010: Fix clk never enabled without CONFIG_PM Brandon Brnich
2026-08-31 21:32 ` [PATCH v4 3/4] media: imagination: e5010: Move e5010_init_device to Runtime Resume Hook Brandon Brnich
2026-08-31 21:32 ` [PATCH v4 4/4] media: imagination: e5010: Enable autosuspend for runtime PM Brandon Brnich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831213231.2125544-2-b-brnich@ti.com \
--to=b-brnich@ti.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devarsht@ti.com \
--cc=hverkuil@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sebastian.fricke@collabora.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox