Re: [PATCH v7 14/14] media: v4l2-subdev: Add struct v4l2_subdev_client_info pointer to pad ops

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sakari,

Thank you for the patch.

On Fri, Aug 07, 2026 at 03:24:09PM +0300, Sakari Ailus wrote:
> Add a pointer to const struct v4l2_subdev_client_info to the get_fmt,
> set_fmt, get_selection and set_selection sub-device pad ops. The client
> info struct will soon be used to differentiate UAPI based on client
> capabilities.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---

[snip]

First, a partial review to point out one specific issue in two drivers.

> diff --git a/drivers/media/i2c/imx678.c b/drivers/media/i2c/imx678.c
> index 0efbf43d2fe6..8413fd44d657 100644
> --- a/drivers/media/i2c/imx678.c
> +++ b/drivers/media/i2c/imx678.c
> @@ -849,6 +849,7 @@ static int imx678_enum_frame_size(struct v4l2_subdev *sd,
>  }
>  
>  static int imx678_get_selection(struct v4l2_subdev *sd,
> +				const struct v4l2_subdev_client_info *ci,
>  				struct v4l2_subdev_state *sd_state,
>  				struct v4l2_subdev_selection *sel)
>  {
> @@ -1130,7 +1131,6 @@ static const struct v4l2_subdev_video_ops imx678_video_ops = {
>  static const struct v4l2_subdev_pad_ops imx678_pad_ops = {
>  	.enum_mbus_code = imx678_enum_mbus_code,
>  	.get_fmt = v4l2_subdev_get_fmt,
> -	.set_fmt = v4l2_subdev_get_fmt,

This belongs to patch 10/14.

>  	.get_selection = imx678_get_selection,
>  	.enum_frame_size = imx678_enum_frame_size,
>  	.enable_streams = imx678_enable_streams,

[snip]

> diff --git a/drivers/media/i2c/ml86v7667.c b/drivers/media/i2c/ml86v7667.c
> index 48b7d589df31..eda41a80d20c 100644
> --- a/drivers/media/i2c/ml86v7667.c
> +++ b/drivers/media/i2c/ml86v7667.c
> @@ -298,7 +298,6 @@ static const struct v4l2_subdev_video_ops ml86v7667_subdev_video_ops = {
>  static const struct v4l2_subdev_pad_ops ml86v7667_subdev_pad_ops = {
>  	.enum_mbus_code = ml86v7667_enum_mbus_code,
>  	.get_fmt = ml86v7667_fill_fmt,
> -	.set_fmt = ml86v7667_fill_fmt,

This too.

>  	.get_mbus_config = ml86v7667_get_mbus_config,
>  };
>  

[snip]

-- 
Regards,

Laurent Pinchart