Linux Media Controller development
 help / color / mirror / Atom feed
From: Igor Paunovic <royalnet026@gmail.com>
To: Amin Gattout <amin.gattout@gmail.com>
Cc: Igor Paunovic <royalnet026@gmail.com>,
	Dmitry Osipenko <dmitry.osipenko@collabora.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, kernel@collabora.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: synopsys: hdmirx: Remove redundant dev_err_probe()
Date: Mon,  7 Sep 2026 19:00:26 +0200	[thread overview]
Message-ID: <20260907160000.hdmirx-amin-rb-royalnet026@gmail.com> (raw)
In-Reply-To: <20260907-snps_hdmirx-v1-1-760dccc4664c@gmail.com>

Hi Amin,

Checked against 7.2-rc7: devm_request_threaded_irq() goes through
devm_request_result(), which already does
dev_err_probe(dev, rc, "request_irq(%u) ...") on failure, so the message
in the driver was a duplicate.

Reviewed-by: Igor Paunovic <royalnet026@gmail.com>

For Dmitry: this does not overlap with my pending hdmirx audio series
(v4, [1]); the hunks are far enough apart that either can go in first.

[1] https://lore.kernel.org/all/20260721064115.64809-1-royalnet026@gmail.com/

Thanks,
Igor

  reply	other threads:[~2026-09-07 17:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  7:52 [PATCH] media: synopsys: hdmirx: Remove redundant dev_err_probe() Amin Gattout
2026-09-07 17:00 ` Igor Paunovic [this message]
2026-09-09 15:23 ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907160000.hdmirx-amin-rb-royalnet026@gmail.com \
    --to=royalnet026@gmail.com \
    --cc=amin.gattout@gmail.com \
    --cc=dmitry.osipenko@collabora.com \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox