From: Amin Gattout <amin.gattout@gmail.com>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, kernel@collabora.com,
linux-kernel@vger.kernel.org,
Amin Gattout <amin.gattout@gmail.com>
Subject: [PATCH] media: synopsys: hdmirx: Remove redundant dev_err_probe()
Date: Mon, 07 Sep 2026 09:52:45 +0200 [thread overview]
Message-ID: <20260907-snps_hdmirx-v1-1-760dccc4664c@gmail.com> (raw)
The devm_request_threaded_irq() function now automatically logs detailed
error messages on failure. This eliminates the need for driver-specific
dev_err_probe() calls that print generic messages.
Signed-off-by: Amin Gattout <amin.gattout@gmail.com>
---
drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
index 25f8ca0d6d94..b456138c381a 100644
--- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
+++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
@@ -2595,10 +2595,8 @@ static int hdmirx_setup_irq(struct snps_hdmirx_dev *hdmirx_dev,
ret = devm_request_threaded_irq(dev, irq, NULL, hdmirx_dma_irq_handler,
IRQF_ONESHOT, "rk_hdmirx-dma",
hdmirx_dev);
- if (ret) {
- dev_err_probe(dev, ret, "failed to request dma irq\n");
+ if (ret)
return ret;
- }
irq = gpiod_to_irq(hdmirx_dev->detect_5v_gpio);
if (irq < 0) {
---
base-commit: df2908090cda368b01ff43709f51890076c56157
change-id: 20260907-snps_hdmirx-7a30ccc56a49
Best regards,
--
Amin Gattout <amin.gattout@gmail.com>
next reply other threads:[~2026-09-07 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 7:52 Amin Gattout [this message]
2026-09-07 17:00 ` [PATCH] media: synopsys: hdmirx: Remove redundant dev_err_probe() Igor Paunovic
2026-09-09 15:23 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907-snps_hdmirx-v1-1-760dccc4664c@gmail.com \
--to=amin.gattout@gmail.com \
--cc=dmitry.osipenko@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox