[PATCH] media: synopsys: hdmirx: Remove redundant dev_err_probe()

[PATCH] media: synopsys: hdmirx: Remove redundant dev_err_probe()

[Amin Gattout]

The devm_request_threaded_irq() function now automatically logs detailed
error messages on failure. This eliminates the need for driver-specific
dev_err_probe() calls that print generic messages.

Signed-off-by: Amin Gattout <amin.gattout@gmail.com>
---
 drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
index 25f8ca0d6d94..b456138c381a 100644
--- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
+++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
@@ -2595,10 +2595,8 @@ static int hdmirx_setup_irq(struct snps_hdmirx_dev *hdmirx_dev,
 	ret = devm_request_threaded_irq(dev, irq, NULL, hdmirx_dma_irq_handler,
 					IRQF_ONESHOT, "rk_hdmirx-dma",
 					hdmirx_dev);
-	if (ret) {
-		dev_err_probe(dev, ret, "failed to request dma irq\n");
+	if (ret)
 		return ret;
-	}
 
 	irq = gpiod_to_irq(hdmirx_dev->detect_5v_gpio);
 	if (irq < 0) {

---
base-commit: df2908090cda368b01ff43709f51890076c56157
change-id: 20260907-snps_hdmirx-7a30ccc56a49

Best regards,
--  
Amin Gattout <amin.gattout@gmail.com>

Re: [PATCH] media: synopsys: hdmirx: Remove redundant dev_err_probe()

[Igor Paunovic]

Hi Amin,

Checked against 7.2-rc7: devm_request_threaded_irq() goes through
devm_request_result(), which already does
dev_err_probe(dev, rc, "request_irq(%u) ...") on failure, so the message
in the driver was a duplicate.

Reviewed-by: Igor Paunovic <royalnet026@gmail.com>

For Dmitry: this does not overlap with my pending hdmirx audio series
(v4, [1]); the hunks are far enough apart that either can go in first.

[1] https://lore.kernel.org/all/20260721064115.64809-1-royalnet026@gmail.com/

Thanks,
Igor

Re: [PATCH] media: synopsys: hdmirx: Remove redundant dev_err_probe()

[Dmitry Osipenko]

On 9/7/26 10:52, Amin Gattout wrote:
> The devm_request_threaded_irq() function now automatically logs detailed
> error messages on failure. This eliminates the need for driver-specific
> dev_err_probe() calls that print generic messages.
> 
> Signed-off-by: Amin Gattout <amin.gattout@gmail.com>
> ---
>  drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> index 25f8ca0d6d94..b456138c381a 100644
> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> @@ -2595,10 +2595,8 @@ static int hdmirx_setup_irq(struct snps_hdmirx_dev *hdmirx_dev,
>  	ret = devm_request_threaded_irq(dev, irq, NULL, hdmirx_dma_irq_handler,
>  					IRQF_ONESHOT, "rk_hdmirx-dma",
>  					hdmirx_dev);
> -	if (ret) {
> -		dev_err_probe(dev, ret, "failed to request dma irq\n");
> +	if (ret)
>  		return ret;
> -	}
>  
>  	irq = gpiod_to_irq(hdmirx_dev->detect_5v_gpio);
>  	if (irq < 0) {
> 
> ---
> base-commit: df2908090cda368b01ff43709f51890076c56157
> change-id: 20260907-snps_hdmirx-7a30ccc56a49
> 
> Best regards,
> --  
> Amin Gattout <amin.gattout@gmail.com>
> 

Acked-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

-- 
Best regards,
Dmitry