From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: Antti Laakso <antti.laakso@linux.intel.com>,
Tarang Raval <tarang.raval@siliconsignals.io>,
"hao.yao@intel.com" <hao.yao@intel.com>,
"dongcheng.yan@intel.com" <dongcheng.yan@intel.com>,
Mehdi Djait <mehdi.djait@linux.intel.com>
Subject: [PATCH 3/4] media: ov05c10: Power management fixes
Date: Fri, 9 Oct 2026 00:05:02 +0300 [thread overview]
Message-ID: <20261008210503.1878442-4-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20261008210503.1878442-1-sakari.ailus@linux.intel.com>
If the device wasn't powered on in probe(), probe failure led to it still
being powered off. Fix this.
Also disable autosuspend in remove().
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/i2c/ov05c10.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov05c10.c b/drivers/media/i2c/ov05c10.c
index 900aa84ddbc3..cd64a621ff48 100644
--- a/drivers/media/i2c/ov05c10.c
+++ b/drivers/media/i2c/ov05c10.c
@@ -920,7 +920,8 @@ static int ov05c10_probe(struct i2c_client *client)
v4l2_ctrl_handler_free(ov05c10->sd.ctrl_handler);
probe_error_power_off:
- ov05c10_power_off(&client->dev);
+ if (full_power)
+ ov05c10_power_off(&client->dev);
return ret;
}
@@ -934,6 +935,7 @@ static void ov05c10_remove(struct i2c_client *client)
v4l2_subdev_cleanup(sd);
media_entity_cleanup(&ov05c10->sd.entity);
v4l2_ctrl_handler_free(&ov05c10->ctrl_handler);
+ pm_runtime_dont_use_autosuspend(&client->dev);
pm_runtime_disable(&client->dev);
if (!pm_runtime_status_suspended(&client->dev)) {
--
2.47.3
next prev parent reply other threads:[~2026-10-08 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 21:04 [PATCH 0/4] ov05c10 cleanups and fixes Sakari Ailus
2026-10-08 21:05 ` [PATCH 1/4] media: ov05c10: Small cleanups Sakari Ailus
2026-10-09 6:39 ` Tarang Raval
2026-10-08 21:05 ` [PATCH 2/4] media: ov05c10: Set reset GPIO high when acquiring it Sakari Ailus
2026-10-09 6:41 ` Tarang Raval
2026-10-08 21:05 ` Sakari Ailus [this message]
2026-10-09 6:57 ` [PATCH 3/4] media: ov05c10: Power management fixes Tarang Raval
2026-10-09 8:15 ` Sakari Ailus
2026-10-08 21:05 ` [PATCH 4/4] media: ov05c10: Remove duplicated writes to analogue gain register Sakari Ailus
2026-10-09 6:58 ` Tarang Raval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008210503.1878442-4-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=antti.laakso@linux.intel.com \
--cc=dongcheng.yan@intel.com \
--cc=hao.yao@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=tarang.raval@siliconsignals.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox