From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Tarang Raval <tarang.raval@siliconsignals.io>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Antti Laakso <antti.laakso@linux.intel.com>,
"hao.yao@intel.com" <hao.yao@intel.com>,
"dongcheng.yan@intel.com" <dongcheng.yan@intel.com>,
Mehdi Djait <mehdi.djait@linux.intel.com>
Subject: Re: [PATCH 3/4] media: ov05c10: Power management fixes
Date: Fri, 9 Oct 2026 11:15:56 +0300 [thread overview]
Message-ID: <asiivEyRy0Fe7-c2@kekkonen.localdomain> (raw)
In-Reply-To: <PN3P287MB18299D33CBBCB0F99F098AD58B922@PN3P287MB1829.INDP287.PROD.OUTLOOK.COM>
Hi Tarang,
On Fri, Oct 09, 2026 at 06:57:57AM +0000, Tarang Raval wrote:
> Hi Sakari,
>
> > If the device wasn't powered on in probe(), probe failure led to it still
> > being powered off. Fix this.
> >
> > Also disable autosuspend in remove().
>
> If v4l2_async_register_subdev_sensor() fails when full_power is true,
> the runtime PM status remains active while the sensor is powered off.
>
> Should we call pm_runtime_set_suspended() in probe_error_rpm, under the
> full_power condition?
Correct. I missed this earlier so I'll add that in v2.
> other than that, LGTM.
>
> Reviewed-by: Tarang Raval <tarang.raval@siliconsignals.io>
Thanks!
--
Sakari Ailus
next prev parent reply other threads:[~2026-10-09 8:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 21:04 [PATCH 0/4] ov05c10 cleanups and fixes Sakari Ailus
2026-10-08 21:05 ` [PATCH 1/4] media: ov05c10: Small cleanups Sakari Ailus
2026-10-09 6:39 ` Tarang Raval
2026-10-08 21:05 ` [PATCH 2/4] media: ov05c10: Set reset GPIO high when acquiring it Sakari Ailus
2026-10-09 6:41 ` Tarang Raval
2026-10-08 21:05 ` [PATCH 3/4] media: ov05c10: Power management fixes Sakari Ailus
2026-10-09 6:57 ` Tarang Raval
2026-10-09 8:15 ` Sakari Ailus [this message]
2026-10-08 21:05 ` [PATCH 4/4] media: ov05c10: Remove duplicated writes to analogue gain register Sakari Ailus
2026-10-09 6:58 ` Tarang Raval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asiivEyRy0Fe7-c2@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=antti.laakso@linux.intel.com \
--cc=dongcheng.yan@intel.com \
--cc=hao.yao@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=tarang.raval@siliconsignals.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox