From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Manivannan Sadhasivam <mani@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH 09/11] media: i2c: imx290: Remove duplicated write to IMX290_CTRL_07
Date: Fri, 03 Feb 2023 08:45:10 +0100 [thread overview]
Message-ID: <2145604.Icojqenx9y@steina-w> (raw)
In-Reply-To: <20230131192016.3476937-10-dave.stevenson@raspberrypi.com>
Hi Dave,
thank you for the patch.
Am Dienstag, 31. Januar 2023, 20:20:14 CET schrieb Dave Stevenson:
> IMX290_CTRL_07 was written from both imx290_global_init_settings
> and imx290_1080p_settings and imx290_720p_settings.
>
> Remove it from imx290_global_init_settings as the setting varies
> based on the mode.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
> drivers/media/i2c/imx290.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index 3413d83369ba..5202ef3cc3e6 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -219,7 +219,6 @@ static inline struct imx290 *to_imx290(struct
> v4l2_subdev *_sd) */
>
> static const struct imx290_regval imx290_global_init_settings[] = {
> - { IMX290_CTRL_07, IMX290_WINMODE_1080P },
> { IMX290_EXTCK_FREQ, 0x2520 },
> { IMX290_WINWV_OB, 12 },
> { IMX290_WINPH, 0 },
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
next prev parent reply other threads:[~2023-02-03 7:45 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 19:20 [PATCH 00/11] imx290: Minor fixes, support for alternate INCK, and more ctrls Dave Stevenson
2023-01-31 19:20 ` [PATCH 01/11] media: i2c: imx290: Match kernel coding style on whitespace Dave Stevenson
2023-02-02 0:21 ` Laurent Pinchart
2023-01-31 19:20 ` [PATCH 02/11] media: i2c: imx290: Set the colorspace fields in the format Dave Stevenson
2023-02-02 0:29 ` Laurent Pinchart
2023-01-31 19:20 ` [PATCH 03/11] media: i2c: imx290: Add V4L2_SUBDEV_FL_HAS_EVENTS and subscribe hooks Dave Stevenson
2023-02-02 0:29 ` Laurent Pinchart
2023-02-03 8:54 ` Alexander Stein
2023-01-31 19:20 ` [PATCH 04/11] media: i2c: imx290: Fix the pixel rate at 148.5Mpix/s Dave Stevenson
2023-02-02 8:13 ` Laurent Pinchart
2023-01-31 19:20 ` [PATCH 05/11] media: i2c: imx290: Support 60fps in 2 lane operation Dave Stevenson
2023-02-02 10:50 ` Laurent Pinchart
2023-02-03 8:50 ` Alexander Stein
2023-01-31 19:20 ` [PATCH 06/11] media: i2c: imx290: Use CSI timings as per datasheet Dave Stevenson
2023-02-02 14:36 ` Laurent Pinchart
2023-02-03 8:04 ` Alexander Stein
2023-02-03 9:09 ` Dave Stevenson
2023-01-31 19:20 ` [PATCH 07/11] media: i2c: imx290: Convert V4L2_CID_HBLANK to read/write Dave Stevenson
2023-02-02 14:58 ` Laurent Pinchart
2023-02-02 15:48 ` Dave Stevenson
2023-02-02 22:14 ` Laurent Pinchart
2023-02-03 7:19 ` Alexander Stein
2023-02-03 8:05 ` Dave Stevenson
2023-02-03 8:39 ` Alexander Stein
2023-01-31 19:20 ` [PATCH 08/11] media: i2c: imx290: Convert V4L2_CID_VBLANK " Dave Stevenson
2023-02-02 15:40 ` Alexander Stein
2023-02-02 16:04 ` Dave Stevenson
2023-02-02 17:42 ` Dave Stevenson
2023-02-03 7:16 ` Alexander Stein
2023-02-02 16:01 ` Laurent Pinchart
2023-01-31 19:20 ` [PATCH 09/11] media: i2c: imx290: Remove duplicated write to IMX290_CTRL_07 Dave Stevenson
2023-02-02 16:04 ` Laurent Pinchart
2023-02-03 7:45 ` Alexander Stein [this message]
2023-01-31 19:20 ` [PATCH 10/11] media: i2c: imx290: Add support for 74.25MHz external clock Dave Stevenson
2023-02-02 22:03 ` Laurent Pinchart
2023-02-03 17:04 ` Dave Stevenson
2023-02-03 18:04 ` Laurent Pinchart
2023-02-03 7:44 ` Alexander Stein
2023-02-03 8:59 ` Laurent Pinchart
2023-02-03 9:30 ` Dave Stevenson
2023-01-31 19:20 ` [PATCH 11/11] media: i2c: imx290: Add support for H & V Flips Dave Stevenson
2023-02-02 22:10 ` Laurent Pinchart
2023-02-03 10:21 ` Dave Stevenson
2023-02-03 18:01 ` Laurent Pinchart
2023-02-03 7:35 ` Alexander Stein
2023-02-03 7:57 ` Dave Stevenson
2023-02-03 8:33 ` Alexander Stein
2023-02-03 9:47 ` Dave Stevenson
2023-02-02 22:16 ` [PATCH 00/11] imx290: Minor fixes, support for alternate INCK, and more ctrls Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2145604.Icojqenx9y@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox