* [PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum
@ 2017-09-13 7:35 Ricardo Ribalda Delgado
2017-09-13 8:31 ` Sakari Ailus
2017-09-15 1:54 ` Laurent Pinchart
0 siblings, 2 replies; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2017-09-13 7:35 UTC (permalink / raw)
To: Laurent Pinchart, Mauro Carvalho Chehab, Hans Verkuil,
Laurent Pinchart, Sakari Ailus, Tiffany Lin, Wu-Cheng Li,
linux-media, linux-kernel
Cc: Ricardo Ribalda Delgado
max_width and max_height are swap with step_width and step_height.
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
Since that this bug has been here for ever. I do not know if we should
notify stable or not
I have also cut the lines to respect the 80 char limit
v2: Suggested by Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-Fix indentation
drivers/media/v4l2-core/v4l2-ioctl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
index b60a6b0841d1..0292f327467d 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -730,9 +730,9 @@ static void v4l_print_frmsizeenum(const void *arg, bool write_only)
break;
case V4L2_FRMSIZE_TYPE_STEPWISE:
pr_cont(", min=%ux%u, max=%ux%u, step=%ux%u\n",
- p->stepwise.min_width, p->stepwise.min_height,
- p->stepwise.step_width, p->stepwise.step_height,
- p->stepwise.max_width, p->stepwise.max_height);
+ p->stepwise.min_width, p->stepwise.min_height,
+ p->stepwise.max_width, p->stepwise.max_height,
+ p->stepwise.step_width, p->stepwise.step_height);
break;
case V4L2_FRMSIZE_TYPE_CONTINUOUS:
/* fall through */
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum
2017-09-13 7:35 [PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum Ricardo Ribalda Delgado
@ 2017-09-13 8:31 ` Sakari Ailus
2017-09-15 1:54 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2017-09-13 8:31 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: Laurent Pinchart, Mauro Carvalho Chehab, Hans Verkuil,
Laurent Pinchart, Sakari Ailus, Tiffany Lin, Wu-Cheng Li,
linux-media, linux-kernel
On Wed, Sep 13, 2017 at 09:35:52AM +0200, Ricardo Ribalda Delgado wrote:
> max_width and max_height are swap with step_width and step_height.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>
> Since that this bug has been here for ever. I do not know if we should
> notify stable or not
>
> I have also cut the lines to respect the 80 char limit
>
> v2: Suggested by Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> -Fix indentation
>
> drivers/media/v4l2-core/v4l2-ioctl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index b60a6b0841d1..0292f327467d 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -730,9 +730,9 @@ static void v4l_print_frmsizeenum(const void *arg, bool write_only)
> break;
> case V4L2_FRMSIZE_TYPE_STEPWISE:
> pr_cont(", min=%ux%u, max=%ux%u, step=%ux%u\n",
> - p->stepwise.min_width, p->stepwise.min_height,
> - p->stepwise.step_width, p->stepwise.step_height,
> - p->stepwise.max_width, p->stepwise.max_height);
> + p->stepwise.min_width, p->stepwise.min_height,
> + p->stepwise.max_width, p->stepwise.max_height,
> + p->stepwise.step_width, p->stepwise.step_height);
> break;
> case V4L2_FRMSIZE_TYPE_CONTINUOUS:
> /* fall through */
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum
2017-09-13 7:35 [PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum Ricardo Ribalda Delgado
2017-09-13 8:31 ` Sakari Ailus
@ 2017-09-15 1:54 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2017-09-15 1:54 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: Mauro Carvalho Chehab, Hans Verkuil, Laurent Pinchart,
Sakari Ailus, Tiffany Lin, Wu-Cheng Li, linux-media, linux-kernel
Hi Ricardo,
Thank you for the patch.
On Wednesday, 13 September 2017 10:35:52 EEST Ricardo Ribalda Delgado wrote:
> max_width and max_height are swap with step_width and step_height.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> Since that this bug has been here for ever. I do not know if we should
> notify stable or not
>
> I have also cut the lines to respect the 80 char limit
>
> v2: Suggested by Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> -Fix indentation
>
> drivers/media/v4l2-core/v4l2-ioctl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
> b/drivers/media/v4l2-core/v4l2-ioctl.c index b60a6b0841d1..0292f327467d
> 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -730,9 +730,9 @@ static void v4l_print_frmsizeenum(const void *arg, bool
> write_only) break;
> case V4L2_FRMSIZE_TYPE_STEPWISE:
> pr_cont(", min=%ux%u, max=%ux%u, step=%ux%u\n",
> - p->stepwise.min_width, p->stepwise.min_height,
> - p->stepwise.step_width, p->stepwise.step_height,
> - p->stepwise.max_width, p->stepwise.max_height);
> + p->stepwise.min_width, p->stepwise.min_height,
> + p->stepwise.max_width, p->stepwise.max_height,
> + p->stepwise.step_width, p->stepwise.step_height);
> break;
> case V4L2_FRMSIZE_TYPE_CONTINUOUS:
> /* fall through */
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-15 1:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-13 7:35 [PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum Ricardo Ribalda Delgado
2017-09-13 8:31 ` Sakari Ailus
2017-09-15 1:54 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox