Re: [PATCH v6] media: qcom: iris: move OPP handling to VPU power transaction

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 7/29/26 3:10 AM, Hungyu Lin wrote:
> The power-domain helpers currently update the OPP for core->dev while
> enabling or disabling one functional power domain. This makes a
> transaction-wide performance state depend on a low-level helper and can
> leave the maximum OPP selected when a later power-domain resume fails.
> 
> Move the maximum OPP request to iris_vpu_power_on(), after the ICC vote
> and before powering on the controller and hardware. Unwind the OPP vote
> together with the ICC vote on failures.
> 
> Keep the power-domain helpers limited to runtime PM and use
> pm_runtime_resume_and_get() so a failed resume does not leave the usage
> counter incremented.
> 
> Fixes: bb8a95aa038e ("media: iris: implement power management")
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---

> --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c
> +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c
> @@ -472,10 +472,14 @@ int iris_vpu_power_on(struct iris_core *core)
>  	if (ret)
>  		goto err;
>  
> -	ret = core->iris_platform_data->vpu_ops->power_on_controller(core);
> +	ret = iris_opp_set_rate(core->dev, ULONG_MAX);
>  	if (ret)
>  		goto err_unvote_icc;
>  
> +	ret = core->iris_platform_data->vpu_ops->power_on_controller(core);
> +	if (ret)
> +		goto err_opp;
> +
>  	ret = core->iris_platform_data->vpu_ops->power_on_hw(core);
>  	if (ret)
>  		goto err_power_off_ctrl;
> @@ -495,6 +499,8 @@ int iris_vpu_power_on(struct iris_core *core)
>  
>  err_power_off_ctrl:
>  	core->iris_platform_data->vpu_ops->power_off_controller(core);
> +err_opp:
> +	iris_opp_set_rate(core->dev, 0);

iris_opp_set_rate(0) will almost never do what you want - it will set the
rate to something lower, but not disable the clocks or drop the power
vote. Dropping the vote will happen as the device (runtime) suspends.

This is an existing "issue" in the driver

Konrad