* Re: [PATCH] s5p-mfc: Fix setting controls
@ 2012-06-21 23:46 NAVEEN KRISHNA CHATRADHI
2012-06-26 9:33 ` Kamil Debski
0 siblings, 1 reply; 3+ messages in thread
From: NAVEEN KRISHNA CHATRADHI @ 2012-06-21 23:46 UTC (permalink / raw)
To: Kamil Debski, linux-media@vger.kernel.org
Cc: Marek Szyprowski, Kyungmin Park, Jeongtae Park
Hello Kamil,
Sorry for the delayed reply. I'm afraid this doesnt fix the whole issue.
Still there is some problem with S_CTRL when used with custom controls.
when my application call s_ctrl with V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY
the call finally lands on V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER in driver (The set value is also lost).
I think this is because of corruption of the master or cluster in v4l2-ioctl.c/ctrl.c and pointing to the standard controls master.
instead of the custom control master.
Kindly, let me know your opinion or any clues on this.
Thanks & Regards
Naveen Krishna
------- Original Message -------
Sender : Kamil Debski<k.debski@samsung.com> Software Engineer/Poland R&D Center-Linux Platform (SSD)/Samsung Electronics
Date : Jun 15, 2012 13:51 (GMT+05:00)
Title : [PATCH] s5p-mfc: Fix setting controls
Fixed s_ctrl function when setting the following controls:
- V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER
- V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY
Signed-off-by: Kamil Debski <k.debski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/media/video/s5p-mfc/s5p_mfc_dec.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_dec.c b/drivers/media/video/s5p-mfc/s5p_mfc_dec.c
index e1ebc76..eaab13e 100644
--- a/drivers/media/video/s5p-mfc/s5p_mfc_dec.c
+++ b/drivers/media/video/s5p-mfc/s5p_mfc_dec.c
@@ -639,13 +639,13 @@ static int s5p_mfc_dec_s_ctrl(struct v4l2_ctrl *ctrl)
switch (ctrl->id) {
case V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY:
- ctx->loop_filter_mpeg4 = ctrl->val;
+ ctx->display_delay = ctrl->val;
break;
case V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY_ENABLE:
ctx->display_delay_enable = ctrl->val;
break;
case V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER:
- ctx->display_delay = ctrl->val;
+ ctx->loop_filter_mpeg4 = ctrl->val;
break;
case V4L2_CID_MPEG_VIDEO_DECODER_SLICE_INTERFACE:
ctx->slice_interface = ctrl->val;
--
1.7.0.4
<p> </p><p> </p>Thanks & Best Regards,
Naveen Krishna Ch
SE @ Samsung-B.LAB
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] s5p-mfc: Fix setting controls
2012-06-21 23:46 [PATCH] s5p-mfc: Fix setting controls NAVEEN KRISHNA CHATRADHI
@ 2012-06-26 9:33 ` Kamil Debski
0 siblings, 0 replies; 3+ messages in thread
From: Kamil Debski @ 2012-06-26 9:33 UTC (permalink / raw)
To: ch.naveen, linux-media
Cc: 'Marek Szyprowski', 'Kyungmin Park',
'Jeongtae Park'
Hi Naveen,
Today I have posted a patch that should resolve your problems with setting
controls
([PATCH] s5p-mfc: Fixed setup of custom controls in decoder and encoder).
Please check if it works now.
Best wishes,
--
Kamil Debski
Linux Platform Group
Samsung Poland R&D Center
> -----Original Message-----
> From: NAVEEN KRISHNA CHATRADHI [mailto:ch.naveen@samsung.com]
> Sent: 22 June 2012 01:47
> To: Kamil Debski; linux-media@vger.kernel.org
> Cc: Marek Szyprowski; Kyungmin Park; Jeongtae Park
> Subject: Re: [PATCH] s5p-mfc: Fix setting controls
>
> Hello Kamil,
>
> Sorry for the delayed reply. I'm afraid this doesnt fix the whole issue.
> Still there is some problem with S_CTRL when used with custom controls.
>
> when my application call s_ctrl with
> V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY
> the call finally lands on
> V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER in driver (The set value
> is also lost).
>
> I think this is because of corruption of the master or cluster in v4l2-
> ioctl.c/ctrl.c and pointing to the standard controls master.
> instead of the custom control master.
>
> Kindly, let me know your opinion or any clues on this.
>
> Thanks & Regards
> Naveen Krishna
>
>
>
> ------- Original Message -------
> Sender : Kamil Debski<k.debski@samsung.com> Software Engineer/Poland R&D
> Center-Linux Platform (SSD)/Samsung Electronics
> Date : Jun 15, 2012 13:51 (GMT+05:00)
> Title : [PATCH] s5p-mfc: Fix setting controls
>
> Fixed s_ctrl function when setting the following controls:
> - V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER
> - V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY
>
> Signed-off-by: Kamil Debski <k.debski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/media/video/s5p-mfc/s5p_mfc_dec.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_dec.c
> b/drivers/media/video/s5p-mfc/s5p_mfc_dec.c
> index e1ebc76..eaab13e 100644
> --- a/drivers/media/video/s5p-mfc/s5p_mfc_dec.c
> +++ b/drivers/media/video/s5p-mfc/s5p_mfc_dec.c
> @@ -639,13 +639,13 @@ static int s5p_mfc_dec_s_ctrl(struct v4l2_ctrl
> *ctrl)
>
> switch (ctrl->id) {
> case V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY:
> - ctx->loop_filter_mpeg4 = ctrl->val;
> + ctx->display_delay = ctrl->val;
> break;
> case V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY_ENABLE:
> ctx->display_delay_enable = ctrl->val;
> break;
> case V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER:
> - ctx->display_delay = ctrl->val;
> + ctx->loop_filter_mpeg4 = ctrl->val;
> break;
> case V4L2_CID_MPEG_VIDEO_DECODER_SLICE_INTERFACE:
> ctx->slice_interface = ctrl->val;
> --
> 1.7.0.4
>
> <p> </p><p> </p>Thanks & Best Regards,
> Naveen Krishna Ch
> SE @ Samsung-B.LAB
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] s5p-mfc: Fix setting controls
@ 2012-06-15 8:51 Kamil Debski
0 siblings, 0 replies; 3+ messages in thread
From: Kamil Debski @ 2012-06-15 8:51 UTC (permalink / raw)
To: linux-media
Cc: m.szyprowski, kyungmin.park, jtp.park, ch.naveen, Kamil Debski
Fixed s_ctrl function when setting the following controls:
- V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER
- V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY
Signed-off-by: Kamil Debski <k.debski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/media/video/s5p-mfc/s5p_mfc_dec.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_dec.c b/drivers/media/video/s5p-mfc/s5p_mfc_dec.c
index e1ebc76..eaab13e 100644
--- a/drivers/media/video/s5p-mfc/s5p_mfc_dec.c
+++ b/drivers/media/video/s5p-mfc/s5p_mfc_dec.c
@@ -639,13 +639,13 @@ static int s5p_mfc_dec_s_ctrl(struct v4l2_ctrl *ctrl)
switch (ctrl->id) {
case V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY:
- ctx->loop_filter_mpeg4 = ctrl->val;
+ ctx->display_delay = ctrl->val;
break;
case V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY_ENABLE:
ctx->display_delay_enable = ctrl->val;
break;
case V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER:
- ctx->display_delay = ctrl->val;
+ ctx->loop_filter_mpeg4 = ctrl->val;
break;
case V4L2_CID_MPEG_VIDEO_DECODER_SLICE_INTERFACE:
ctx->slice_interface = ctrl->val;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-26 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-21 23:46 [PATCH] s5p-mfc: Fix setting controls NAVEEN KRISHNA CHATRADHI
2012-06-26 9:33 ` Kamil Debski
-- strict thread matches above, loose matches on Subject: below --
2012-06-15 8:51 Kamil Debski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox