* [PATCH] v4l: v4l2-ctrls: Add forward declaration of struct file
@ 2012-04-23 11:29 Laurent Pinchart
2012-04-29 16:30 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2012-04-23 11:29 UTC (permalink / raw)
To: linux-media; +Cc: hans.verkuil
This fixes the following warning:
In file included from drivers/media/video/v4l2-subdev.c:29:
include/media/v4l2-ctrls.h:501: warning: 'struct file' declared inside
parameter list
include/media/v4l2-ctrls.h:501: warning: its scope is only this
definition or declaration, which is probably not what you want
include/media/v4l2-ctrls.h:509: warning: 'struct file' declared inside
parameter list
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
include/media/v4l2-ctrls.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
index 33907a9..9022e1c 100644
--- a/include/media/v4l2-ctrls.h
+++ b/include/media/v4l2-ctrls.h
@@ -25,6 +25,7 @@
#include <linux/videodev2.h>
/* forward references */
+struct file;
struct v4l2_ctrl_handler;
struct v4l2_ctrl_helper;
struct v4l2_ctrl;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] v4l: v4l2-ctrls: Add forward declaration of struct file
2012-04-23 11:29 [PATCH] v4l: v4l2-ctrls: Add forward declaration of struct file Laurent Pinchart
@ 2012-04-29 16:30 ` Laurent Pinchart
2012-05-08 11:55 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2012-04-29 16:30 UTC (permalink / raw)
To: linux-media; +Cc: hans.verkuil
On Monday 23 April 2012 13:29:11 Laurent Pinchart wrote:
> This fixes the following warning:
>
> In file included from drivers/media/video/v4l2-subdev.c:29:
> include/media/v4l2-ctrls.h:501: warning: 'struct file' declared inside
> parameter list
> include/media/v4l2-ctrls.h:501: warning: its scope is only this
> definition or declaration, which is probably not what you want
> include/media/v4l2-ctrls.h:509: warning: 'struct file' declared inside
> parameter list
Ping ? Should I include this in my next pull request ?
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> include/media/v4l2-ctrls.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
> index 33907a9..9022e1c 100644
> --- a/include/media/v4l2-ctrls.h
> +++ b/include/media/v4l2-ctrls.h
> @@ -25,6 +25,7 @@
> #include <linux/videodev2.h>
>
> /* forward references */
> +struct file;
> struct v4l2_ctrl_handler;
> struct v4l2_ctrl_helper;
> struct v4l2_ctrl;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] v4l: v4l2-ctrls: Add forward declaration of struct file
2012-04-29 16:30 ` Laurent Pinchart
@ 2012-05-08 11:55 ` Hans Verkuil
0 siblings, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2012-05-08 11:55 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media, hans.verkuil
On Sun 29 April 2012 18:30:24 Laurent Pinchart wrote:
> On Monday 23 April 2012 13:29:11 Laurent Pinchart wrote:
> > This fixes the following warning:
> >
> > In file included from drivers/media/video/v4l2-subdev.c:29:
> > include/media/v4l2-ctrls.h:501: warning: 'struct file' declared inside
> > parameter list
> > include/media/v4l2-ctrls.h:501: warning: its scope is only this
> > definition or declaration, which is probably not what you want
> > include/media/v4l2-ctrls.h:509: warning: 'struct file' declared inside
> > parameter list
>
> Ping ? Should I include this in my next pull request ?
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > include/media/v4l2-ctrls.h | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
> > index 33907a9..9022e1c 100644
> > --- a/include/media/v4l2-ctrls.h
> > +++ b/include/media/v4l2-ctrls.h
> > @@ -25,6 +25,7 @@
> > #include <linux/videodev2.h>
> >
> > /* forward references */
> > +struct file;
> > struct v4l2_ctrl_handler;
> > struct v4l2_ctrl_helper;
> > struct v4l2_ctrl;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-08 11:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-23 11:29 [PATCH] v4l: v4l2-ctrls: Add forward declaration of struct file Laurent Pinchart
2012-04-29 16:30 ` Laurent Pinchart
2012-05-08 11:55 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox