* [PATCH] Fix to qt1010 tuner frequency selection (media/dvb)
@ 2011-08-22 17:19 Jyrki Kuoppala
2011-09-25 16:13 ` Carlos Corbacho
0 siblings, 1 reply; 6+ messages in thread
From: Jyrki Kuoppala @ 2011-08-22 17:19 UTC (permalink / raw)
To: linux-media; +Cc: linux-kernel, Mauro Carvalho Chehab
The patch fixes frequency selection for some UHF frequencies e.g.
channel 32 (562 MHz) on the qt1010 tuner. The tuner is used e.g. in the
MSI Mega Sky dvb-t stick ("MSI Mega Sky 55801 DVB-T USB2.0")
One example of problem reports of the bug this fixes can be read at
http://www.freak-search.com/de/thread/330303/linux-dvb_tuning_problem_with_some_frequencies_qt1010,_dvb
Applies to kernel versions 2.6.38.8, 2.6.39.4, 3.0.3 and 3.1-rc2.
Signed-off-by: Jyrki Kuoppala <jkp@iki.fi>
diff -upr linux-source-2.6.38.orig/drivers/media/common/tuners/qt1010.c
linux-source-2.6.38/drivers/media/common/tuners/qt1010.c
--- linux-source-2.6.38.orig/drivers/media/common/tuners/qt1010.c
2011-03-15 03:20:32.000000000 +0200
+++ linux-source-2.6.38/drivers/media/common/tuners/qt1010.c
2011-08-21 23:16:38.209580365 +0300
@@ -198,9 +198,10 @@ static int qt1010_set_params(struct dvb_
/* 22 */
if (freq < 450000000) rd[15].val = 0xd0; /* 450 MHz */
- else if (freq < 482000000) rd[15].val = 0xd1; /* 482 MHz */
+ else if (freq < 482000000) rd[15].val = 0xd2; /* 482 MHz */
else if (freq < 514000000) rd[15].val = 0xd4; /* 514 MHz */
- else if (freq < 546000000) rd[15].val = 0xd7; /* 546 MHz */
+ else if (freq < 546000000) rd[15].val = 0xd6; /* 546 MHz */
+ else if (freq < 578000000) rd[15].val = 0xd8; /* 578 MHz */
else if (freq < 610000000) rd[15].val = 0xda; /* 610 MHz */
else rd[15].val = 0xd0;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Fix to qt1010 tuner frequency selection (media/dvb)
2011-08-22 17:19 [PATCH] Fix to qt1010 tuner frequency selection (media/dvb) Jyrki Kuoppala
@ 2011-09-25 16:13 ` Carlos Corbacho
2011-09-25 16:37 ` Jyrki Kuoppala
0 siblings, 1 reply; 6+ messages in thread
From: Carlos Corbacho @ 2011-09-25 16:13 UTC (permalink / raw)
To: Jyrki Kuoppala; +Cc: linux-media, linux-kernel, Mauro Carvalho Chehab
On Monday 22 Aug 2011 20:19:42 Jyrki Kuoppala wrote:
> The patch fixes frequency selection for some UHF frequencies e.g.
> channel 32 (562 MHz) on the qt1010 tuner. The tuner is used e.g. in the
> MSI Mega Sky dvb-t stick ("MSI Mega Sky 55801 DVB-T USB2.0")
>
> One example of problem reports of the bug this fixes can be read at
> http://www.freak-search.com/de/thread/330303/linux-dvb_tuning_problem_with_s
> ome_frequencies_qt1010,_dvb
>
> Applies to kernel versions 2.6.38.8, 2.6.39.4, 3.0.3 and 3.1-rc2.
>
> Signed-off-by: Jyrki Kuoppala <jkp@iki.fi>
Cc: stable@kernel.org
Tested-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
This patch means I can now finally tune to all the BBC channels (which are on
channel 31 (554 MHz) in my area). This should definitely go to stable, as I've
also seen other similar reports for users who can't tune to various channels
in the affected ranges here using qt1010.
Mauro - I don't see this one in your git tree in the 3.2 branch, or in the
temporary linuxtv patchwork, so I'm assuming this one fell between the cracks?
-Carlos
> diff -upr linux-source-2.6.38.orig/drivers/media/common/tuners/qt1010.c
> linux-source-2.6.38/drivers/media/common/tuners/qt1010.c
> --- linux-source-2.6.38.orig/drivers/media/common/tuners/qt1010.c
> 2011-03-15 03:20:32.000000000 +0200
> +++ linux-source-2.6.38/drivers/media/common/tuners/qt1010.c
> 2011-08-21 23:16:38.209580365 +0300
> @@ -198,9 +198,10 @@ static int qt1010_set_params(struct dvb_
>
> /* 22 */
> if (freq < 450000000) rd[15].val = 0xd0; /* 450 MHz */
> - else if (freq < 482000000) rd[15].val = 0xd1; /* 482 MHz */
> + else if (freq < 482000000) rd[15].val = 0xd2; /* 482 MHz */
> else if (freq < 514000000) rd[15].val = 0xd4; /* 514 MHz */
> - else if (freq < 546000000) rd[15].val = 0xd7; /* 546 MHz */
> + else if (freq < 546000000) rd[15].val = 0xd6; /* 546 MHz */
> + else if (freq < 578000000) rd[15].val = 0xd8; /* 578 MHz */
> else if (freq < 610000000) rd[15].val = 0xda; /* 610 MHz */
> else rd[15].val = 0xd0;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Fix to qt1010 tuner frequency selection (media/dvb)
2011-09-25 16:13 ` Carlos Corbacho
@ 2011-09-25 16:37 ` Jyrki Kuoppala
2011-10-19 21:06 ` Carlos Corbacho
0 siblings, 1 reply; 6+ messages in thread
From: Jyrki Kuoppala @ 2011-09-25 16:37 UTC (permalink / raw)
To: Carlos Corbacho; +Cc: linux-media, linux-kernel, Mauro Carvalho Chehab
I haven't gotten any feedback, and didn't see any comments on the lists
(though I've checked them only occasionally), so I think you're probably
right it fell between the cracks.
Jyrki
25.09.2011 19:13, Carlos Corbacho kirjoitti:
> On Monday 22 Aug 2011 20:19:42 Jyrki Kuoppala wrote:
>> The patch fixes frequency selection for some UHF frequencies e.g.
>> channel 32 (562 MHz) on the qt1010 tuner. The tuner is used e.g. in the
>> MSI Mega Sky dvb-t stick ("MSI Mega Sky 55801 DVB-T USB2.0")
>>
>> One example of problem reports of the bug this fixes can be read at
>> http://www.freak-search.com/de/thread/330303/linux-dvb_tuning_problem_with_s
>> ome_frequencies_qt1010,_dvb
>>
>> Applies to kernel versions 2.6.38.8, 2.6.39.4, 3.0.3 and 3.1-rc2.
>>
>> Signed-off-by: Jyrki Kuoppala<jkp@iki.fi>
> Cc: stable@kernel.org
> Tested-by: Carlos Corbacho<carlos@strangeworlds.co.uk>
>
> This patch means I can now finally tune to all the BBC channels (which are on
> channel 31 (554 MHz) in my area). This should definitely go to stable, as I've
> also seen other similar reports for users who can't tune to various channels
> in the affected ranges here using qt1010.
>
> Mauro - I don't see this one in your git tree in the 3.2 branch, or in the
> temporary linuxtv patchwork, so I'm assuming this one fell between the cracks?
>
> -Carlos
>
>> diff -upr linux-source-2.6.38.orig/drivers/media/common/tuners/qt1010.c
>> linux-source-2.6.38/drivers/media/common/tuners/qt1010.c
>> --- linux-source-2.6.38.orig/drivers/media/common/tuners/qt1010.c
>> 2011-03-15 03:20:32.000000000 +0200
>> +++ linux-source-2.6.38/drivers/media/common/tuners/qt1010.c
>> 2011-08-21 23:16:38.209580365 +0300
>> @@ -198,9 +198,10 @@ static int qt1010_set_params(struct dvb_
>>
>> /* 22 */
>> if (freq< 450000000) rd[15].val = 0xd0; /* 450 MHz */
>> - else if (freq< 482000000) rd[15].val = 0xd1; /* 482 MHz */
>> + else if (freq< 482000000) rd[15].val = 0xd2; /* 482 MHz */
>> else if (freq< 514000000) rd[15].val = 0xd4; /* 514 MHz */
>> - else if (freq< 546000000) rd[15].val = 0xd7; /* 546 MHz */
>> + else if (freq< 546000000) rd[15].val = 0xd6; /* 546 MHz */
>> + else if (freq< 578000000) rd[15].val = 0xd8; /* 578 MHz */
>> else if (freq< 610000000) rd[15].val = 0xda; /* 610 MHz */
>> else rd[15].val = 0xd0;
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Fix to qt1010 tuner frequency selection (media/dvb)
2011-09-25 16:37 ` Jyrki Kuoppala
@ 2011-10-19 21:06 ` Carlos Corbacho
2011-10-20 4:45 ` Jyrki Kuoppala
0 siblings, 1 reply; 6+ messages in thread
From: Carlos Corbacho @ 2011-10-19 21:06 UTC (permalink / raw)
To: Jyrki Kuoppala; +Cc: linux-media, linux-kernel, Mauro Carvalho Chehab
Jyrki,
So after a bit more testing...
[...]
> >> /* 22 */
> >> if (freq< 450000000) rd[15].val = 0xd0; /* 450 MHz
> >> */
> >>
> >> - else if (freq< 482000000) rd[15].val = 0xd1; /* 482 MHz */
> >> + else if (freq< 482000000) rd[15].val = 0xd2; /* 482 MHz */
This change isn't so good.
With this change, I can no longer tune to channel 21 (474 MHz). If I revert it
back to 0xd1, it's fine.
[...]
> >>
> >> else if (freq< 514000000) rd[15].val = 0xd4; /* 514 MHz
> >> */
> >>
> >> - else if (freq< 546000000) rd[15].val = 0xd7; /* 546 MHz */
> >> + else if (freq< 546000000) rd[15].val = 0xd6; /* 546 MHz */
> >> + else if (freq< 578000000) rd[15].val = 0xd8; /* 578 MHz */
(This change is still good though, as this does allow me to now tune to the
BBC channels in this range).
-Carlos
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix to qt1010 tuner frequency selection (media/dvb)
2011-10-19 21:06 ` Carlos Corbacho
@ 2011-10-20 4:45 ` Jyrki Kuoppala
2011-10-23 8:18 ` Carlos Corbacho
0 siblings, 1 reply; 6+ messages in thread
From: Jyrki Kuoppala @ 2011-10-20 4:45 UTC (permalink / raw)
To: Carlos Corbacho; +Cc: linux-media, linux-kernel, Mauro Carvalho Chehab
I think my problem frequency has also been at the later spot. It is possible there is something more complicated going on at 474 MHz - so based on your testing, it's best to apply just the latter change, at least for now.
Jyrki
+ else if (freq< 546000000) rd[15].val = 0xd6; /* 546 MHz */
+ else if (freq< 546000000) rd[15].val = 0xd6; /* 546 MHz */
20.10.2011 00:06, Carlos Corbacho kirjoitti:
> Jyrki,
>
> So after a bit more testing...
>
> [...]
>
>>>> /* 22 */
>>>> if (freq< 450000000) rd[15].val = 0xd0; /* 450 MHz
>>>> */
>>>>
>>>> - else if (freq< 482000000) rd[15].val = 0xd1; /* 482 MHz */
>>>> + else if (freq< 482000000) rd[15].val = 0xd2; /* 482 MHz */
> This change isn't so good.
>
> With this change, I can no longer tune to channel 21 (474 MHz). If I revert it
> back to 0xd1, it's fine.
>
> [...]
>
>>>> else if (freq< 514000000) rd[15].val = 0xd4; /* 514 MHz
>>>> */
>>>>
>>>> - else if (freq< 546000000) rd[15].val = 0xd7; /* 546 MHz */
>>>> + else if (freq< 546000000) rd[15].val = 0xd6; /* 546 MHz */
>>>> + else if (freq< 578000000) rd[15].val = 0xd8; /* 578 MHz */
> (This change is still good though, as this does allow me to now tune to the
> BBC channels in this range).
>
> -Carlos
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix to qt1010 tuner frequency selection (media/dvb)
2011-10-20 4:45 ` Jyrki Kuoppala
@ 2011-10-23 8:18 ` Carlos Corbacho
0 siblings, 0 replies; 6+ messages in thread
From: Carlos Corbacho @ 2011-10-23 8:18 UTC (permalink / raw)
To: Jyrki Kuoppala; +Cc: linux-media, linux-kernel, Mauro Carvalho Chehab
On Thursday 20 Oct 2011 07:45:45 Jyrki Kuoppala wrote:
> I think my problem frequency has also been at the later spot. It is possible
> there is something more complicated going on at 474 MHz - so based on your
> testing, it's best to apply just the latter change, at least for now.
>
> Jyrki
>
>
>
> + else if (freq< 546000000) rd[15].val = 0xd6; /* 546 MHz */
>
> + else if (freq< 546000000) rd[15].val = 0xd6; /* 546 MHz */
Are you going to resubmit the patch with just these changes (you can add my
Tested-by to that), or if you want, I can take care of resubmitting it?
-Carlos
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-10-23 8:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-22 17:19 [PATCH] Fix to qt1010 tuner frequency selection (media/dvb) Jyrki Kuoppala
2011-09-25 16:13 ` Carlos Corbacho
2011-09-25 16:37 ` Jyrki Kuoppala
2011-10-19 21:06 ` Carlos Corbacho
2011-10-20 4:45 ` Jyrki Kuoppala
2011-10-23 8:18 ` Carlos Corbacho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox