* [PATCH] media: ov2740: change the minimal exposure value to 4
@ 2020-10-21 2:44 Bingbu Cao
2020-10-21 9:20 ` Sakari Ailus
0 siblings, 1 reply; 4+ messages in thread
From: Bingbu Cao @ 2020-10-21 2:44 UTC (permalink / raw)
To: linux-media, sakari.ailus; +Cc: senozhatsky, tfiga, bingbu.cao, bingbu.cao
The minimal valid exposure value should be 4 lines instead of 8 for
ov2740 mannual exposure control.
Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
---
drivers/media/i2c/ov2740.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c
index bd0d45b0d43f..0dbae4949cb3 100644
--- a/drivers/media/i2c/ov2740.c
+++ b/drivers/media/i2c/ov2740.c
@@ -37,7 +37,7 @@
/* Exposure controls from sensor */
#define OV2740_REG_EXPOSURE 0x3500
-#define OV2740_EXPOSURE_MIN 8
+#define OV2740_EXPOSURE_MIN 4
#define OV2740_EXPOSURE_MAX_MARGIN 8
#define OV2740_EXPOSURE_STEP 1
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] media: ov2740: change the minimal exposure value to 4
2020-10-21 2:44 [PATCH] media: ov2740: change the minimal exposure value to 4 Bingbu Cao
@ 2020-10-21 9:20 ` Sakari Ailus
2020-10-21 10:12 ` Bingbu Cao
0 siblings, 1 reply; 4+ messages in thread
From: Sakari Ailus @ 2020-10-21 9:20 UTC (permalink / raw)
To: Bingbu Cao; +Cc: linux-media, senozhatsky, tfiga, bingbu.cao
Hi Bingbu,
On Wed, Oct 21, 2020 at 10:44:10AM +0800, Bingbu Cao wrote:
> The minimal valid exposure value should be 4 lines instead of 8 for
> ov2740 mannual exposure control.
>
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> ---
> drivers/media/i2c/ov2740.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c
> index bd0d45b0d43f..0dbae4949cb3 100644
> --- a/drivers/media/i2c/ov2740.c
> +++ b/drivers/media/i2c/ov2740.c
> @@ -37,7 +37,7 @@
>
> /* Exposure controls from sensor */
> #define OV2740_REG_EXPOSURE 0x3500
> -#define OV2740_EXPOSURE_MIN 8
> +#define OV2740_EXPOSURE_MIN 4
> #define OV2740_EXPOSURE_MAX_MARGIN 8
> #define OV2740_EXPOSURE_STEP 1
This is already in my tree --- I may forgotten to push master after
applying many patches, it is up-to-date now.
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: ov2740: change the minimal exposure value to 4
2020-10-21 9:20 ` Sakari Ailus
@ 2020-10-21 10:12 ` Bingbu Cao
2020-10-21 10:33 ` Sakari Ailus
0 siblings, 1 reply; 4+ messages in thread
From: Bingbu Cao @ 2020-10-21 10:12 UTC (permalink / raw)
To: Sakari Ailus, Bingbu Cao; +Cc: linux-media, senozhatsky, tfiga
Sakari, thanks.
I did not find that on patchwork, so resend it again. :)
On 10/21/20 5:20 PM, Sakari Ailus wrote:
> Hi Bingbu,
>
> On Wed, Oct 21, 2020 at 10:44:10AM +0800, Bingbu Cao wrote:
>> The minimal valid exposure value should be 4 lines instead of 8 for
>> ov2740 mannual exposure control.
>>
>> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
>> ---
>> drivers/media/i2c/ov2740.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c
>> index bd0d45b0d43f..0dbae4949cb3 100644
>> --- a/drivers/media/i2c/ov2740.c
>> +++ b/drivers/media/i2c/ov2740.c
>> @@ -37,7 +37,7 @@
>>
>> /* Exposure controls from sensor */
>> #define OV2740_REG_EXPOSURE 0x3500
>> -#define OV2740_EXPOSURE_MIN 8
>> +#define OV2740_EXPOSURE_MIN 4
>> #define OV2740_EXPOSURE_MAX_MARGIN 8
>> #define OV2740_EXPOSURE_STEP 1
>
> This is already in my tree --- I may forgotten to push master after
> applying many patches, it is up-to-date now.
>
--
Best regards,
Bingbu Cao
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: ov2740: change the minimal exposure value to 4
2020-10-21 10:12 ` Bingbu Cao
@ 2020-10-21 10:33 ` Sakari Ailus
0 siblings, 0 replies; 4+ messages in thread
From: Sakari Ailus @ 2020-10-21 10:33 UTC (permalink / raw)
To: Bingbu Cao; +Cc: Bingbu Cao, linux-media, senozhatsky, tfiga
Hi Bingbu,
On Wed, Oct 21, 2020 at 06:12:16PM +0800, Bingbu Cao wrote:
> Sakari, thanks.
> I did not find that on patchwork, so resend it again. :)
That patch simply seems to have been lost. It's also not on the list, only
in my inbox.
We've had e-mail delivery problems recently both ways, I suppose this is
attributable to those.
Thanks for resending so others could also see it.
--
Regards,
Sakari Ailus
P.S. Please avoid top posting.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-21 10:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-21 2:44 [PATCH] media: ov2740: change the minimal exposure value to 4 Bingbu Cao
2020-10-21 9:20 ` Sakari Ailus
2020-10-21 10:12 ` Bingbu Cao
2020-10-21 10:33 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox