From: Federico Vaga <federico.vaga@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Pawel Osciak <pawel@osciak.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH 3/3 v2] [media] sta2x11_vip: convert to videobuf2 and control framework
Date: Mon, 06 Aug 2012 10:55:06 +0200 [thread overview]
Message-ID: <2930909.DTsasJxcLr@harkonnen> (raw)
In-Reply-To: <201208061042.03658.hverkuil@xs4all.nl>
> > + vip->video_dev->flags |= V4L2_FL_USES_V4L2_FH |
> > V4L2_FL_USE_FH_PRIO;
> Been there, done that :-)
>
> V4L2_FL_USE_FH_PRIO is a bit number, not a bit mask. Use set_bit
> instead:
>
> set_bit(V4L2_FL_USE_FH_PRIO, &vip->video_dev->flags);
>
> No need to set V4L2_FL_USES_V4L2_FH, BTW. That will be set
> automatically as soon as v4l2_fh_open is called.
I saw "unsigned long flags;" in the header but without reading the
comment :) Thank you. I will test it in these days but I think it's all
done.
--
Federico Vaga
next prev parent reply other threads:[~2012-08-06 8:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 20:17 Update VIP to videobuf2 and control framework Federico Vaga
2012-07-31 20:17 ` [PATCH 1/3] [media] adv7180: remove {query/g_/s_}ctrl Federico Vaga
2012-07-31 20:20 ` Federico Vaga
2012-08-12 1:46 ` Mauro Carvalho Chehab
2012-07-31 20:17 ` [PATCH 2/3] [media] videobuf2-dma-streaming: new videobuf2 memory allocator Federico Vaga
2012-08-20 8:03 ` Marek Szyprowski
2012-08-24 13:23 ` Federico Vaga
2012-08-24 13:40 ` Marek Szyprowski
2012-08-24 13:48 ` Federico Vaga
2012-07-31 20:17 ` [PATCH 3/3] [media] sta2x11_vip: convert to videobuf2 and control framework Federico Vaga
2012-08-06 8:17 ` [PATCH 3/3 v2] " Federico Vaga
2012-08-06 8:42 ` Hans Verkuil
2012-08-06 8:55 ` Federico Vaga [this message]
2012-07-31 20:27 ` Update VIP " Federico Vaga
2012-08-01 6:41 ` Hans Verkuil
2012-08-01 13:04 ` Jonathan Corbet
2012-08-16 11:29 ` Federico Vaga
2012-08-05 17:11 ` Federico Vaga
2012-08-06 7:26 ` Hans Verkuil
2012-08-06 7:38 ` Federico Vaga
2012-08-06 7:36 ` Hans Verkuil
2012-08-06 8:20 ` Federico Vaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2930909.DTsasJxcLr@harkonnen \
--to=federico.vaga@gmail.com \
--cc=corbet@lwn.net \
--cc=giancarlo.asnaghi@st.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@infradead.org \
--cc=pawel@osciak.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox