From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Jae Hyun Yoo" <jae.hyun.yoo@linux.intel.com>,
"Eddie James" <eajames@linux.ibm.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Joel Stanley" <joel@jms.id.au>
Cc: linux-aspeed@lists.ozlabs.org, linux-media@vger.kernel.org,
openbmc@lists.ozlabs.org
Subject: Re: [PATCH -next 2/2] media: aspeed: set hsync and vsync polarities to normal before starting mode detection
Date: Fri, 13 Sep 2019 09:48:56 +0930 [thread overview]
Message-ID: <2c24c8a9-b357-4948-8744-3900ed28012c@www.fastmail.com> (raw)
In-Reply-To: <490bc4d9-e471-3b0f-49c9-39e99af95d62@linux.intel.com>
On Fri, 13 Sep 2019, at 02:36, Jae Hyun Yoo wrote:
> On 9/11/2019 10:39 PM, Andrew Jeffery wrote:
> >
> >
> > On Wed, 11 Sep 2019, at 04:37, Jae Hyun Yoo wrote:
> >> Sometimes it detects a weird resolution such as 1024x287 when the
> >> actual resolution is 1024x768. To resolve such an issue, this
> >> commit adds clearing for hsync and vsync polarity register bits
> >> at the beginning of the first mode detection. This is recommended
> >> in the datasheet.
> >
> > I guess this answers my question on the previous patch's commit
> > message. Maybe it should be in both?
>
> I think the previous patch is a bug fix and this one is an enhancement
> patch. Better splitting them.
I wasn't suggesting squashing the patches, I was suggesting updating
the commit message of the first patch to better justify/explain the
change.
Andrew
next prev parent reply other threads:[~2019-09-13 0:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 19:07 [PATCH -next 0/2] media: aspeed: refine mode detection flow Jae Hyun Yoo
2019-09-10 19:07 ` [PATCH -next 1/2] media: aspeed: refine hsync/vsync polarity setting logic Jae Hyun Yoo
2019-09-12 5:33 ` Andrew Jeffery
2019-09-12 17:04 ` Jae Hyun Yoo
2019-09-10 19:07 ` [PATCH -next 2/2] media: aspeed: set hsync and vsync polarities to normal before starting mode detection Jae Hyun Yoo
2019-09-12 5:39 ` Andrew Jeffery
2019-09-12 17:06 ` Jae Hyun Yoo
2019-09-13 0:18 ` Andrew Jeffery [this message]
2019-09-13 16:14 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c24c8a9-b357-4948-8744-3900ed28012c@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox