public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Tony Lindgren <tony@atomide.com>,
	linux-media@vger.kernel.org, Sakari Ailus <sakari.ailus@iki.fi>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap3isp: Don't include <plat/cpu.h>
Date: Mon, 07 Jan 2013 02:14:20 +0100	[thread overview]
Message-ID: <30855273.UsAOH7UnCd@avalon> (raw)
In-Reply-To: <20130106111039.627d5dab@redhat.com>

Hi Mauro,

On Sunday 06 January 2013 11:10:39 Mauro Carvalho Chehab wrote:
> Em Thu, 3 Jan 2013 14:55:41 -0800 Tony Lindgren escreveu:
> > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [130103 13:24]:
> > > The plat/*.h headers are not available to drivers in multiplatform
> > > kernels. As the header isn't needed, just remove it.
> > 
> > Please consider merging this for the -rc cycle, so I can make
> > plat/cpu.h produce an error for omap2+ to prevent new drivers
> > including it.
> 
> Ok, I'll add it to the list of patches for 3.8.

Thank you.

Could you please also add "omap3isp: Don't include deleted OMAP plat/ header 
files" to that list ? And Sakari, could you please ack it ?

> > Acked-by: Tony Lindgren <tony@atomide.com>
> > 
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > > 
> > >  drivers/media/platform/omap3isp/isp.c |    2 --
> > >  1 files changed, 0 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/media/platform/omap3isp/isp.c
> > > b/drivers/media/platform/omap3isp/isp.c index 50cea08..07eea5b 100644
> > > --- a/drivers/media/platform/omap3isp/isp.c
> > > +++ b/drivers/media/platform/omap3isp/isp.c
> > > @@ -71,8 +71,6 @@
> > > 
> > >  #include <media/v4l2-common.h>
> > >  #include <media/v4l2-device.h>
> > > 
> > > -#include <plat/cpu.h>
> > > -
> > > 
> > >  #include "isp.h"
> > >  #include "ispreg.h"
> > >  #include "ispccdc.h"

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2013-01-07  1:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-03 21:23 [PATCH] omap3isp: Don't include <plat/cpu.h> Laurent Pinchart
2013-01-03 22:55 ` Tony Lindgren
2013-01-06 13:10   ` Mauro Carvalho Chehab
2013-01-07  1:14     ` Laurent Pinchart [this message]
2013-01-04 23:06 ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30855273.UsAOH7UnCd@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=sakari.ailus@iki.fi \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox