* [PATCH] omap3isp: Don't include <plat/cpu.h>
@ 2013-01-03 21:23 Laurent Pinchart
2013-01-03 22:55 ` Tony Lindgren
2013-01-04 23:06 ` Sakari Ailus
0 siblings, 2 replies; 5+ messages in thread
From: Laurent Pinchart @ 2013-01-03 21:23 UTC (permalink / raw)
To: linux-media; +Cc: Sakari Ailus, linux-omap, Tony Lindgren
The plat/*.h headers are not available to drivers in multiplatform
kernels. As the header isn't needed, just remove it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/platform/omap3isp/isp.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
index 50cea08..07eea5b 100644
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -71,8 +71,6 @@
#include <media/v4l2-common.h>
#include <media/v4l2-device.h>
-#include <plat/cpu.h>
-
#include "isp.h"
#include "ispreg.h"
#include "ispccdc.h"
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] omap3isp: Don't include <plat/cpu.h>
2013-01-03 21:23 [PATCH] omap3isp: Don't include <plat/cpu.h> Laurent Pinchart
@ 2013-01-03 22:55 ` Tony Lindgren
2013-01-06 13:10 ` Mauro Carvalho Chehab
2013-01-04 23:06 ` Sakari Ailus
1 sibling, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2013-01-03 22:55 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media, Sakari Ailus, linux-omap
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [130103 13:24]:
> The plat/*.h headers are not available to drivers in multiplatform
> kernels. As the header isn't needed, just remove it.
Please consider merging this for the -rc cycle, so I can make
plat/cpu.h produce an error for omap2+ to prevent new drivers
including it.
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/platform/omap3isp/isp.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
> index 50cea08..07eea5b 100644
> --- a/drivers/media/platform/omap3isp/isp.c
> +++ b/drivers/media/platform/omap3isp/isp.c
> @@ -71,8 +71,6 @@
> #include <media/v4l2-common.h>
> #include <media/v4l2-device.h>
>
> -#include <plat/cpu.h>
> -
> #include "isp.h"
> #include "ispreg.h"
> #include "ispccdc.h"
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] omap3isp: Don't include <plat/cpu.h>
2013-01-03 22:55 ` Tony Lindgren
@ 2013-01-06 13:10 ` Mauro Carvalho Chehab
2013-01-07 1:14 ` Laurent Pinchart
0 siblings, 1 reply; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2013-01-06 13:10 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Laurent Pinchart, linux-media, Sakari Ailus, linux-omap
Em Thu, 3 Jan 2013 14:55:41 -0800
Tony Lindgren <tony@atomide.com> escreveu:
> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [130103 13:24]:
> > The plat/*.h headers are not available to drivers in multiplatform
> > kernels. As the header isn't needed, just remove it.
>
> Please consider merging this for the -rc cycle, so I can make
> plat/cpu.h produce an error for omap2+ to prevent new drivers
> including it.
Ok, I'll add it to the list of patches for 3.8.
Regards,
Mauro
>
> Acked-by: Tony Lindgren <tony@atomide.com>
>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > drivers/media/platform/omap3isp/isp.c | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
> > index 50cea08..07eea5b 100644
> > --- a/drivers/media/platform/omap3isp/isp.c
> > +++ b/drivers/media/platform/omap3isp/isp.c
> > @@ -71,8 +71,6 @@
> > #include <media/v4l2-common.h>
> > #include <media/v4l2-device.h>
> >
> > -#include <plat/cpu.h>
> > -
> > #include "isp.h"
> > #include "ispreg.h"
> > #include "ispccdc.h"
> > --
> > Regards,
> >
> > Laurent Pinchart
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Cheers,
Mauro
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] omap3isp: Don't include <plat/cpu.h>
2013-01-06 13:10 ` Mauro Carvalho Chehab
@ 2013-01-07 1:14 ` Laurent Pinchart
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2013-01-07 1:14 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Tony Lindgren, linux-media, Sakari Ailus, linux-omap
Hi Mauro,
On Sunday 06 January 2013 11:10:39 Mauro Carvalho Chehab wrote:
> Em Thu, 3 Jan 2013 14:55:41 -0800 Tony Lindgren escreveu:
> > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [130103 13:24]:
> > > The plat/*.h headers are not available to drivers in multiplatform
> > > kernels. As the header isn't needed, just remove it.
> >
> > Please consider merging this for the -rc cycle, so I can make
> > plat/cpu.h produce an error for omap2+ to prevent new drivers
> > including it.
>
> Ok, I'll add it to the list of patches for 3.8.
Thank you.
Could you please also add "omap3isp: Don't include deleted OMAP plat/ header
files" to that list ? And Sakari, could you please ack it ?
> > Acked-by: Tony Lindgren <tony@atomide.com>
> >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > >
> > > drivers/media/platform/omap3isp/isp.c | 2 --
> > > 1 files changed, 0 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/media/platform/omap3isp/isp.c
> > > b/drivers/media/platform/omap3isp/isp.c index 50cea08..07eea5b 100644
> > > --- a/drivers/media/platform/omap3isp/isp.c
> > > +++ b/drivers/media/platform/omap3isp/isp.c
> > > @@ -71,8 +71,6 @@
> > >
> > > #include <media/v4l2-common.h>
> > > #include <media/v4l2-device.h>
> > >
> > > -#include <plat/cpu.h>
> > > -
> > >
> > > #include "isp.h"
> > > #include "ispreg.h"
> > > #include "ispccdc.h"
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] omap3isp: Don't include <plat/cpu.h>
2013-01-03 21:23 [PATCH] omap3isp: Don't include <plat/cpu.h> Laurent Pinchart
2013-01-03 22:55 ` Tony Lindgren
@ 2013-01-04 23:06 ` Sakari Ailus
1 sibling, 0 replies; 5+ messages in thread
From: Sakari Ailus @ 2013-01-04 23:06 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media, linux-omap, Tony Lindgren
On Thu, Jan 03, 2013 at 10:23:24PM +0100, Laurent Pinchart wrote:
> The plat/*.h headers are not available to drivers in multiplatform
> kernels. As the header isn't needed, just remove it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-01-07 1:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-03 21:23 [PATCH] omap3isp: Don't include <plat/cpu.h> Laurent Pinchart
2013-01-03 22:55 ` Tony Lindgren
2013-01-06 13:10 ` Mauro Carvalho Chehab
2013-01-07 1:14 ` Laurent Pinchart
2013-01-04 23:06 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox