From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 7/7] DocBook media: document the new 'which' field.
Date: Mon, 23 Feb 2015 18:46:40 +0200 [thread overview]
Message-ID: <3196637.eIdTnyjkZV@avalon> (raw)
In-Reply-To: <1423827006-32878-8-git-send-email-hverkuil@xs4all.nl>
Hi Hans,
Thank you for the patch.
On Friday 13 February 2015 12:30:06 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> The subdev enum ioctls now have a new 'which' field. Document this.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../DocBook/media/v4l/vidioc-subdev-enum-frame-interval.xml | 13 ++++++----
> .../DocBook/media/v4l/vidioc-subdev-enum-frame-size.xml | 13 ++++++----
> .../DocBook/media/v4l/vidioc-subdev-enum-mbus-code.xml | 11 +++++++---
3 files changed, 26 insertions(+), 11 deletions(-)
>
> diff --git
> a/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-interval.xml
> b/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-interval.xml
> index 2f8f4f0..cff59f5 100644
> --- a/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-interval.xml
> +++ b/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-interval.xml
> @@ -67,9 +67,9 @@
>
> <para>To enumerate frame intervals applications initialize the
> <structfield>index</structfield>, <structfield>pad</structfield>,
> - <structfield>code</structfield>, <structfield>width</structfield> and
> - <structfield>height</structfield> fields of
> - &v4l2-subdev-frame-interval-enum; and call the
> + <structfield>which</structfield>, <structfield>code</structfield>,
> + <structfield>width</structfield> and <structfield>height</structfield>
> + fields of &v4l2-subdev-frame-interval-enum; and call the
> <constant>VIDIOC_SUBDEV_ENUM_FRAME_INTERVAL</constant> ioctl with a
> pointer to this structure. Drivers fill the rest of the structure or return
> an &EINVAL; if one of the input fields is invalid. All frame intervals are
> @@ -123,7 +123,12 @@
> </row>
> <row>
> <entry>__u32</entry>
> - <entry><structfield>reserved</structfield>[9]</entry>
> + <entry><structfield>which</structfield></entry>
> + <entry>Frame intervals to be enumerated, from
> &v4l2-subdev-format-whence;.</entry> + </row>
> + <row>
> + <entry>__u32</entry>
> + <entry><structfield>reserved</structfield>[8]</entry>
> <entry>Reserved for future extensions. Applications and drivers must
> set the array to zero.</entry>
> </row>
> diff --git
> a/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-size.xml
> b/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-size.xml index
> 79ce42b..abd545e 100644
> --- a/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-size.xml
> +++ b/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-size.xml
> @@ -61,9 +61,9 @@
> ioctl.</para>
>
> <para>To enumerate frame sizes applications initialize the
> - <structfield>pad</structfield>, <structfield>code</structfield> and
> - <structfield>index</structfield> fields of the
> - &v4l2-subdev-mbus-code-enum; and call the
> + <structfield>pad</structfield>, <structfield>which</structfield> ,
> + <structfield>code</structfield> and <structfield>index</structfield>
> + fields of the &v4l2-subdev-mbus-code-enum; and call the
> <constant>VIDIOC_SUBDEV_ENUM_FRAME_SIZE</constant> ioctl with a pointer
> to the structure. Drivers fill the minimum and maximum frame sizes or
> return an &EINVAL; if one of the input parameters is invalid.</para> @@
> -127,7 +127,12 @@
> </row>
> <row>
> <entry>__u32</entry>
> - <entry><structfield>reserved</structfield>[9]</entry>
> + <entry><structfield>which</structfield></entry>
> + <entry>Frame sizes to be enumerated, from
> &v4l2-subdev-format-whence;.</entry> + </row>
> + <row>
> + <entry>__u32</entry>
> + <entry><structfield>reserved</structfield>[8]</entry>
> <entry>Reserved for future extensions. Applications and drivers must
> set the array to zero.</entry>
> </row>
> diff --git
> a/Documentation/DocBook/media/v4l/vidioc-subdev-enum-mbus-code.xml
> b/Documentation/DocBook/media/v4l/vidioc-subdev-enum-mbus-code.xml index
> a6b3432..0bcb278 100644
> --- a/Documentation/DocBook/media/v4l/vidioc-subdev-enum-mbus-code.xml
> +++ b/Documentation/DocBook/media/v4l/vidioc-subdev-enum-mbus-code.xml
> @@ -56,8 +56,8 @@
> </note>
>
> <para>To enumerate media bus formats available at a given sub-device
> pad - applications initialize the <structfield>pad</structfield> and -
> <structfield>index</structfield> fields of &v4l2-subdev-mbus-code-enum;
> and + applications initialize the <structfield>pad</structfield>,
> <structfield>which</structfield> + and <structfield>index</structfield>
> fields of &v4l2-subdev-mbus-code-enum; and call the
> <constant>VIDIOC_SUBDEV_ENUM_MBUS_CODE</constant> ioctl with a pointer to
> this structure. Drivers fill the rest of the structure or return an
> &EINVAL; if either the <structfield>pad</structfield> or
> @@ -93,7 +93,12 @@
> </row>
> <row>
> <entry>__u32</entry>
> - <entry><structfield>reserved</structfield>[9]</entry>
> + <entry><structfield>which</structfield></entry>
> + <entry>Media bus format codes to be enumerated, from
> &v4l2-subdev-format-whence;.</entry> + </row>
> + <row>
> + <entry>__u32</entry>
> + <entry><structfield>reserved</structfield>[8]</entry>
> <entry>Reserved for future extensions. Applications and drivers must
> set the array to zero.</entry>
> </row>
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2015-02-23 16:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 11:29 v4l2-subdev: removal of duplicate video enum ops Hans Verkuil
2015-02-13 11:30 ` [PATCH 1/7] v4l2-subdev: replace v4l2_subdev_fh by v4l2_subdev_pad_config Hans Verkuil
2015-02-22 20:03 ` Lad, Prabhakar
2015-02-23 16:28 ` Laurent Pinchart
2015-03-02 9:40 ` Sakari Ailus
2015-02-13 11:30 ` [PATCH 2/7] v4l2-subdev.h: add 'which' field for the enum structs Hans Verkuil
2015-02-23 16:38 ` Laurent Pinchart
2015-02-13 11:30 ` [PATCH 3/7] v4l2-subdev.c: add 'which' checks for enum ops Hans Verkuil
2015-02-23 16:38 ` Laurent Pinchart
2015-02-13 11:30 ` [PATCH 4/7] v4l2-subdev: support new 'which' field in enum_mbus_code Hans Verkuil
2015-02-23 16:40 ` Laurent Pinchart
2015-02-13 11:30 ` [PATCH 5/7] v4l2-subdev: add support for the new enum_frame_size 'which' field Hans Verkuil
2015-02-23 16:44 ` Laurent Pinchart
2015-02-13 11:30 ` [PATCH 6/7] v4l2-subdev: remove enum_framesizes/intervals Hans Verkuil
2015-02-24 8:08 ` Hans Verkuil
2015-02-24 9:30 ` Laurent Pinchart
2015-03-04 8:47 ` Hans Verkuil
2015-03-04 14:31 ` Jonathan Corbet
2015-02-13 11:30 ` [PATCH 7/7] DocBook media: document the new 'which' field Hans Verkuil
2015-02-23 16:46 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3196637.eIdTnyjkZV@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox