Re: [PATCH v3 1/3] media: ipu-bridge: Add DMI information of Lenovo X9 to the image upside-down list

["Mark Pearson" <mpearson@squebb.ca>]

Note - switched to my open-source friendly email account.

Hi Kate,

On Tue, Jun 2, 2026, at 2:35 AM, Kate Hsuan wrote:
> Hi Damjan,
>
> Thank you for your review.
>
> On Sat, May 30, 2026 at 6:33 AM Damjan Georgievski <gdamjan@gmail.com> wrote:
>>
>> On 5/22/26 05:11, Kate Hsuan wrote:
>> > The Lenovo X9 has an upside-down-mounted Sony IMX471 sensor so the image
>> > was displayed upside-down. Add the DMI information of Lenovo X9 to
>> > resolve the issue.
>> >
>> > Signed-off-by: Kate Hsuan <hpa@redhat.com>
>> > ---
>> >   drivers/media/pci/intel/ipu-bridge.c | 14 ++++++++++++++
>> >   1 file changed, 14 insertions(+)
>> >
>> > diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
>> > index 32cc95a766b7..1c3364451fa3 100644
>> > --- a/drivers/media/pci/intel/ipu-bridge.c
>> > +++ b/drivers/media/pci/intel/ipu-bridge.c
>> > @@ -118,6 +118,20 @@ static const struct dmi_system_id upside_down_sensor_dmi_ids[] = {
>> >               },
>> >               .driver_data = "OVTI02C1",
>> >       },
>> > +     {
>> > +             .matches = {
>> > +                     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> > +                     DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X9-14"),
>>
>> Isn't this going to be an issue in the future if/when a "Gen 2" appears?
>
> You can look into the v1 [1]. The DMI_BOARD_NAME is used to
> distinguish the types of X1.
> v3 covers wider ranges of X9-14 and 15. If we agree with v1, I can
> revert this patch to v1.
>
> [1] https://lore.kernel.org/linux-media/20260417083214.222189-2-hpa@redhat.com/
>
I happily defer to Hans on things like this as he has way more experience than me, but we usually use the BOARD_NAME for identifying platforms everywhere else in the kernel so that feels to me 'safer'.

If we do go ahead with PRODUCT_VERSION it should probably be DMI_MATCH_EXACT instead. I think that will work fine, but it is not commonly used and I would worry about the FW team doing weird versions for different markets (the two board names are very standard for Thinkpads)

Mark (currently on vacation - so replies may be delayed)