* [PATCH 1/1] media: amphion: use dev_err_probe
@ 2023-01-31 10:32 Alexander Stein
2023-03-15 6:50 ` Alexander Stein
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Stein @ 2023-01-31 10:32 UTC (permalink / raw)
To: Ming Qian, Shijie Qin, Zhou Peng, Mauro Carvalho Chehab
Cc: Alexander Stein, linux-media
This simplifies the code and silences -517 error messages. Also
the reason is listed in /sys/kernel/debug/devices_deferred.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/media/platform/amphion/vpu_mbox.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/amphion/vpu_mbox.c b/drivers/media/platform/amphion/vpu_mbox.c
index bf759eb2fd46..b6d5b4844f67 100644
--- a/drivers/media/platform/amphion/vpu_mbox.c
+++ b/drivers/media/platform/amphion/vpu_mbox.c
@@ -46,11 +46,10 @@ static int vpu_mbox_request_channel(struct device *dev, struct vpu_mbox *mbox)
cl->rx_callback = vpu_mbox_rx_callback;
ch = mbox_request_channel_byname(cl, mbox->name);
- if (IS_ERR(ch)) {
- dev_err(dev, "Failed to request mbox chan %s, ret : %ld\n",
- mbox->name, PTR_ERR(ch));
- return PTR_ERR(ch);
- }
+ if (IS_ERR(ch))
+ return dev_err_probe(dev, PTR_ERR(ch),
+ "Failed to request mbox chan %s\n",
+ mbox->name);
mbox->ch = ch;
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] media: amphion: use dev_err_probe
2023-01-31 10:32 [PATCH 1/1] media: amphion: use dev_err_probe Alexander Stein
@ 2023-03-15 6:50 ` Alexander Stein
2023-03-17 8:52 ` [EXT] " Ming Qian
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Stein @ 2023-03-15 6:50 UTC (permalink / raw)
To: Ming Qian, Shijie Qin, Zhou Peng, Mauro Carvalho Chehab; +Cc: linux-media
Hi,
Am Dienstag, 31. Januar 2023, 11:32:44 CET schrieb Alexander Stein:
> This simplifies the code and silences -517 error messages. Also
> the reason is listed in /sys/kernel/debug/devices_deferred.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
is there any feedback on this?
Thanks and best regards,
Alexander
> ---
> drivers/media/platform/amphion/vpu_mbox.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/amphion/vpu_mbox.c
> b/drivers/media/platform/amphion/vpu_mbox.c index
> bf759eb2fd46..b6d5b4844f67 100644
> --- a/drivers/media/platform/amphion/vpu_mbox.c
> +++ b/drivers/media/platform/amphion/vpu_mbox.c
> @@ -46,11 +46,10 @@ static int vpu_mbox_request_channel(struct device *dev,
> struct vpu_mbox *mbox) cl->rx_callback = vpu_mbox_rx_callback;
>
> ch = mbox_request_channel_byname(cl, mbox->name);
> - if (IS_ERR(ch)) {
> - dev_err(dev, "Failed to request mbox chan %s, ret :
%ld\n",
> - mbox->name, PTR_ERR(ch));
> - return PTR_ERR(ch);
> - }
> + if (IS_ERR(ch))
> + return dev_err_probe(dev, PTR_ERR(ch),
> + "Failed to request mbox chan
%s\n",
> + mbox->name);
>
> mbox->ch = ch;
> return 0;
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] Re: [PATCH 1/1] media: amphion: use dev_err_probe
2023-03-15 6:50 ` Alexander Stein
@ 2023-03-17 8:52 ` Ming Qian
2023-05-31 7:24 ` Alexander Stein
0 siblings, 1 reply; 4+ messages in thread
From: Ming Qian @ 2023-03-17 8:52 UTC (permalink / raw)
To: Alexander Stein, Shijie Qin, Eagle Zhou, Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
>Hi,
>
>Am Dienstag, 31. Januar 2023, 11:32:44 CET schrieb Alexander Stein:
>> This simplifies the code and silences -517 error messages. Also the
>> reason is listed in /sys/kernel/debug/devices_deferred.
>>
>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: ming_qian <ming.qian@nxp.com>
>
>is there any feedback on this?
>
>Thanks and best regards,
>Alexander
>
>> ---
>> drivers/media/platform/amphion/vpu_mbox.c | 9 ++++-----
>> 1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/media/platform/amphion/vpu_mbox.c
>> b/drivers/media/platform/amphion/vpu_mbox.c index
>> bf759eb2fd46..b6d5b4844f67 100644
>> --- a/drivers/media/platform/amphion/vpu_mbox.c
>> +++ b/drivers/media/platform/amphion/vpu_mbox.c
>> @@ -46,11 +46,10 @@ static int vpu_mbox_request_channel(struct device
>> *dev, struct vpu_mbox *mbox) cl->rx_callback = vpu_mbox_rx_callback;
>>
>> ch = mbox_request_channel_byname(cl, mbox->name);
>> - if (IS_ERR(ch)) {
>> - dev_err(dev, "Failed to request mbox chan %s, ret :
>%ld\n",
>> - mbox->name, PTR_ERR(ch));
>> - return PTR_ERR(ch);
>> - }
>> + if (IS_ERR(ch))
>> + return dev_err_probe(dev, PTR_ERR(ch),
>> + "Failed to request mbox chan
>%s\n",
>> + mbox->name);
>>
>> mbox->ch = ch;
>> return 0;
>
>
>--
>TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
>Amtsgericht München, HRB 105018
>Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
>https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.tq
>-
>group.com%2F&data=05%7C01%7Cming.qian%40nxp.com%7Cf727eee294b74
>d6b250d08db25219119%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
>7C638144598318747307%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw
>MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%
>7C&sdata=UREXcvYNz6K%2FoF%2Bahc7%2Bhos7fv9Lz3N0Fx2u5a%2F8Jlo%3D
>&reserved=0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] Re: [PATCH 1/1] media: amphion: use dev_err_probe
2023-03-17 8:52 ` [EXT] " Ming Qian
@ 2023-05-31 7:24 ` Alexander Stein
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2023-05-31 7:24 UTC (permalink / raw)
To: Shijie Qin, Eagle Zhou, Mauro Carvalho Chehab, Ming Qian
Cc: linux-media@vger.kernel.org
Hi,
Am Freitag, 17. März 2023, 09:52:51 CEST schrieb Ming Qian:
> >Hi,
> >
> >Am Dienstag, 31. Januar 2023, 11:32:44 CET schrieb Alexander Stein:
> >> This simplifies the code and silences -517 error messages. Also the
> >> reason is listed in /sys/kernel/debug/devices_deferred.
> >>
> >> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>
> Reviewed-by: ming_qian <ming.qian@nxp.com>
Thanks. Who is going to pick this patch?
Best regards,
Alexander
> >is there any feedback on this?
> >
> >Thanks and best regards,
> >Alexander
> >
> >> ---
> >>
> >> drivers/media/platform/amphion/vpu_mbox.c | 9 ++++-----
> >> 1 file changed, 4 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/media/platform/amphion/vpu_mbox.c
> >> b/drivers/media/platform/amphion/vpu_mbox.c index
> >> bf759eb2fd46..b6d5b4844f67 100644
> >> --- a/drivers/media/platform/amphion/vpu_mbox.c
> >> +++ b/drivers/media/platform/amphion/vpu_mbox.c
> >> @@ -46,11 +46,10 @@ static int vpu_mbox_request_channel(struct device
> >> *dev, struct vpu_mbox *mbox) cl->rx_callback = vpu_mbox_rx_callback;
> >>
> >> ch = mbox_request_channel_byname(cl, mbox->name);
> >>
> >> - if (IS_ERR(ch)) {
> >
> >> - dev_err(dev, "Failed to request mbox chan %s, ret :
> >%ld\n",
> >
> >> - mbox->name, PTR_ERR(ch));
> >> - return PTR_ERR(ch);
> >> - }
> >> + if (IS_ERR(ch))
> >> + return dev_err_probe(dev, PTR_ERR(ch),
> >> + "Failed to request mbox chan
> >
> >%s\n",
> >
> >> + mbox->name);
> >>
> >> mbox->ch = ch;
> >> return 0;
> >
> >--
> >TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> >Amtsgericht München, HRB 105018
> >Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> >https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.tq
> >-
> >group.com%2F&data=05%7C01%7Cming.qian%40nxp.com%7Cf727eee294b74
> >d6b250d08db25219119%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> >7C638144598318747307%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw
> >MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%
> >7C&sdata=UREXcvYNz6K%2FoF%2Bahc7%2Bhos7fv9Lz3N0Fx2u5a%2F8Jlo%3D
> >&reserved=0
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-31 7:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-31 10:32 [PATCH 1/1] media: amphion: use dev_err_probe Alexander Stein
2023-03-15 6:50 ` Alexander Stein
2023-03-17 8:52 ` [EXT] " Ming Qian
2023-05-31 7:24 ` Alexander Stein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox