Re: linux-next: Tree for March 11 (staging/multimedia)

Re: linux-next: Tree for March 11 (staging/multimedia)

[Randy Dunlap]

Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20090310:


drivers/staging/go7007/go7007-v4l2.c:1830: error: 'VID_TYPE_CAPTURE' undeclared here (not in a function)


-- 
~Randy

Re: linux-next: Tree for March 11 (staging/multimedia)

[Greg KH]

On Wed, Mar 11, 2009 at 10:12:39AM -0700, Randy Dunlap wrote:
> Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20090310:
> 
> 
> drivers/staging/go7007/go7007-v4l2.c:1830: error: 'VID_TYPE_CAPTURE' undeclared here (not in a function)

Odd, nothing has changed in this driver, is this a v4l api change?

thanks,

greg k-h

Re: linux-next: Tree for March 11 (staging/multimedia)

[Randy Dunlap]

Greg KH wrote:
> On Wed, Mar 11, 2009 at 10:12:39AM -0700, Randy Dunlap wrote:
>> Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20090310:
>>
>> drivers/staging/go7007/go7007-v4l2.c:1830: error: 'VID_TYPE_CAPTURE' undeclared here (not in a function)
> 
> Odd, nothing has changed in this driver, is this a v4l api change?

I don't know if the vl4 API changed, but this error has been around
for some time now.  Just because it's just now being reported is one
change.  Surely other people build these drivers.  ???


I do know that other video drivers (with one exception) don't set:
	.vfl_type	= VID_TYPE_CAPTURE,
at all, so maybe it's not needed (?).


-- 
~Randy

Re: linux-next: Tree for March 11 (staging/multimedia)

[Greg KH]

On Wed, Mar 11, 2009 at 11:21:52AM -0700, Randy Dunlap wrote:
> Greg KH wrote:
> > On Wed, Mar 11, 2009 at 10:12:39AM -0700, Randy Dunlap wrote:
> >> Stephen Rothwell wrote:
> >>> Hi all,
> >>>
> >>> Changes since 20090310:
> >>
> >> drivers/staging/go7007/go7007-v4l2.c:1830: error: 'VID_TYPE_CAPTURE' undeclared here (not in a function)
> > 
> > Odd, nothing has changed in this driver, is this a v4l api change?
> 
> I don't know if the vl4 API changed, but this error has been around
> for some time now.  Just because it's just now being reported is one
> change.  Surely other people build these drivers.  ???

I do, and don't seem to get this error.

Ah, it's a CONFIG_VIDEO_V4L1_COMPAT issue.  I'll see what needs to do to
fix this up.

thanks,

greg k-h

Re: linux-next: Tree for March 11 (staging/multimedia)

[Hans Verkuil]

On Wednesday 11 March 2009 19:21:52 Randy Dunlap wrote:
> Greg KH wrote:
> > On Wed, Mar 11, 2009 at 10:12:39AM -0700, Randy Dunlap wrote:
> >> Stephen Rothwell wrote:
> >>> Hi all,
> >>>
> >>> Changes since 20090310:
> >>
> >> drivers/staging/go7007/go7007-v4l2.c:1830: error: 'VID_TYPE_CAPTURE'
> >> undeclared here (not in a function)
> >
> > Odd, nothing has changed in this driver, is this a v4l api change?
>
> I don't know if the vl4 API changed, but this error has been around
> for some time now.  Just because it's just now being reported is one
> change.  Surely other people build these drivers.  ???
>
>
> I do know that other video drivers (with one exception) don't set:
> 	.vfl_type	= VID_TYPE_CAPTURE,
> at all, so maybe it's not needed (?).

That's correct, this assignment isn't needed. The error appears now since 
VID_TYPE_CAPTURE has been made inaccessible for V4L2 drivers. Only old V4L1 
drivers can use it.

This change was very recent and before that it compiled fine. Although even 
then that code was wrong (but harmless).

Just remove that line and it will compile fine again. Although unless 
someone will take this driver to the next level it will probably break 
again once the old autoprobing i2c API is removed (and that's slated for 
2.6.30 if all goes well).

Regards,

	Hans

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG