From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Halim Sahin <halim.sahin@freenet.de>
Cc: linux-media@vger.kernel.org
Subject: Re: add Technisat skystar usb plus USB-ID
Date: Wed, 22 Dec 2010 08:52:20 -0200 [thread overview]
Message-ID: <4D11D864.4090904@redhat.com> (raw)
In-Reply-To: <20101205143116.GA1533@gentoo.local>
Em 05-12-2010 12:31, Halim Sahin escreveu:
> this device is a rebranded Technotrend s-2400 with USB id 0x3009.
> THx to Carsten Wehmeier for reporting
>
> Signed-off-by: Halim Sahin <halim.sahin@freenet.de>
>
> ---
> drivers/media/dvb/dvb-usb/dvb-usb-ids.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
> index 192a40c..380066b 100644
> --- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
> +++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
> @@ -204,6 +204,7 @@
> #define USB_PID_AVERMEDIA_A805 0xa805
> #define USB_PID_AVERMEDIA_A815M 0x815a
> #define USB_PID_TECHNOTREND_CONNECT_S2400 0x3006
> +#define USB_PID_TECHNOTREND_CONNECT_S2400 0x3009
> #define USB_PID_TECHNOTREND_CONNECT_CT3650 0x300d
> #define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY 0x005a
> #define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY_2 0x0081
>
Just adding a new ID at dvb-usb-ids.h is the wrong thing to do. This will break
support for 0x3006 device. Instead, you should add a new definition, with a
different name, and duplicate the board entry at the driver that has support
for this device.
Thanks,
Mauro
prev parent reply other threads:[~2010-12-22 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 14:31 add Technisat skystar usb plus USB-ID Halim Sahin
2010-12-22 10:52 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D11D864.4090904@redhat.com \
--to=mchehab@redhat.com \
--cc=halim.sahin@freenet.de \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox