* add Technisat skystar usb plus USB-ID
@ 2010-12-05 14:31 Halim Sahin
2010-12-22 10:52 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: Halim Sahin @ 2010-12-05 14:31 UTC (permalink / raw)
To: linux-media
this device is a rebranded Technotrend s-2400 with USB id 0x3009.
THx to Carsten Wehmeier for reporting
Signed-off-by: Halim Sahin <halim.sahin@freenet.de>
---
drivers/media/dvb/dvb-usb/dvb-usb-ids.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
index 192a40c..380066b 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
@@ -204,6 +204,7 @@
#define USB_PID_AVERMEDIA_A805 0xa805
#define USB_PID_AVERMEDIA_A815M 0x815a
#define USB_PID_TECHNOTREND_CONNECT_S2400 0x3006
+#define USB_PID_TECHNOTREND_CONNECT_S2400 0x3009
#define USB_PID_TECHNOTREND_CONNECT_CT3650 0x300d
#define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY 0x005a
#define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY_2 0x0081
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: add Technisat skystar usb plus USB-ID
2010-12-05 14:31 add Technisat skystar usb plus USB-ID Halim Sahin
@ 2010-12-22 10:52 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2010-12-22 10:52 UTC (permalink / raw)
To: Halim Sahin; +Cc: linux-media
Em 05-12-2010 12:31, Halim Sahin escreveu:
> this device is a rebranded Technotrend s-2400 with USB id 0x3009.
> THx to Carsten Wehmeier for reporting
>
> Signed-off-by: Halim Sahin <halim.sahin@freenet.de>
>
> ---
> drivers/media/dvb/dvb-usb/dvb-usb-ids.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
> index 192a40c..380066b 100644
> --- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
> +++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
> @@ -204,6 +204,7 @@
> #define USB_PID_AVERMEDIA_A805 0xa805
> #define USB_PID_AVERMEDIA_A815M 0x815a
> #define USB_PID_TECHNOTREND_CONNECT_S2400 0x3006
> +#define USB_PID_TECHNOTREND_CONNECT_S2400 0x3009
> #define USB_PID_TECHNOTREND_CONNECT_CT3650 0x300d
> #define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY 0x005a
> #define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY_2 0x0081
>
Just adding a new ID at dvb-usb-ids.h is the wrong thing to do. This will break
support for 0x3006 device. Instead, you should add a new definition, with a
different name, and duplicate the board entry at the driver that has support
for this device.
Thanks,
Mauro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-22 10:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-05 14:31 add Technisat skystar usb plus USB-ID Halim Sahin
2010-12-22 10:52 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox