From: "Frank Schäfer" <fschaefer.oss@googlemail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: v4l2-ctrls: negative integer control values broken
Date: Fri, 25 Jul 2014 20:25:25 +0200 [thread overview]
Message-ID: <53D2A115.5010209@googlemail.com> (raw)
Hans,
sorry for bothering you with another issue on friday evening. :-/
But it seems that commit 958c7c7e65 ("[media] v4l2-ctrls: fix corner
case in round-to-range code") introduced a regression for controls which
are using a negative integer value range.
All negative values are mapped to the maximum (positive) value (check
em28xx brightness, red and blue balance bridge controls for example).
Reverting this commit makes them working again.
At a first glance I can't find a mistake...
Have a nice weekend,
Frank
next reply other threads:[~2014-07-25 18:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 18:25 Frank Schäfer [this message]
2014-07-25 18:27 ` v4l2-ctrls: negative integer control values broken Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D2A115.5010209@googlemail.com \
--to=fschaefer.oss@googlemail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox