* v4l2-ctrls: negative integer control values broken
@ 2014-07-25 18:25 Frank Schäfer
2014-07-25 18:27 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Frank Schäfer @ 2014-07-25 18:25 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List
Hans,
sorry for bothering you with another issue on friday evening. :-/
But it seems that commit 958c7c7e65 ("[media] v4l2-ctrls: fix corner
case in round-to-range code") introduced a regression for controls which
are using a negative integer value range.
All negative values are mapped to the maximum (positive) value (check
em28xx brightness, red and blue balance bridge controls for example).
Reverting this commit makes them working again.
At a first glance I can't find a mistake...
Have a nice weekend,
Frank
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: v4l2-ctrls: negative integer control values broken
2014-07-25 18:25 v4l2-ctrls: negative integer control values broken Frank Schäfer
@ 2014-07-25 18:27 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2014-07-25 18:27 UTC (permalink / raw)
To: Frank Schäfer; +Cc: Linux Media Mailing List
On 07/25/2014 08:25 PM, Frank Schäfer wrote:
> Hans,
>
> sorry for bothering you with another issue on friday evening. :-/
> But it seems that commit 958c7c7e65 ("[media] v4l2-ctrls: fix corner
> case in round-to-range code") introduced a regression for controls which
> are using a negative integer value range.
> All negative values are mapped to the maximum (positive) value (check
> em28xx brightness, red and blue balance bridge controls for example).
> Reverting this commit makes them working again.
> At a first glance I can't find a mistake...
I'll take a look at this this weekend. Thanks for reporting this!
Hans
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-25 18:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-25 18:25 v4l2-ctrls: negative integer control values broken Frank Schäfer
2014-07-25 18:27 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox