[PATCH] Documentation/video4linux: don't build without CONFIG_VIDEO_V4L2

[PATCH] Documentation/video4linux: don't build without CONFIG_VIDEO_V4L2

[Andrey Vagin]

Otherwise we get warnings:
WARNING: "vb2_ops_wait_finish" [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
WARNING: "vb2_ops_wait_prepare" [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
...
WARNING: "video_unregister_device" [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!

Fixes: 8db5ab4b50fb ("Documentation: add makefiles for more targets")

Cc: Peter Foley <pefoley2@pefoley.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
---
 Documentation/video4linux/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/video4linux/Makefile b/Documentation/video4linux/Makefile
index d58101e..f19f38e 100644
--- a/Documentation/video4linux/Makefile
+++ b/Documentation/video4linux/Makefile
@@ -1 +1,3 @@
+ifneq ($(CONFIG_VIDEO_V4L2),)
 obj-m := v4l2-pci-skeleton.o
+endif
-- 
1.9.3

Re: [PATCH] Documentation/video4linux: don't build without CONFIG_VIDEO_V4L2

[Randy Dunlap]

On 08/28/14 13:34, Andrey Vagin wrote:
> Otherwise we get warnings:
> WARNING: "vb2_ops_wait_finish" [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
> WARNING: "vb2_ops_wait_prepare" [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
> ...
> WARNING: "video_unregister_device" [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
> 
> Fixes: 8db5ab4b50fb ("Documentation: add makefiles for more targets")
> 
> Cc: Peter Foley <pefoley2@pefoley.com>
> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Andrey Vagin <avagin@openvz.org>
> ---
>  Documentation/video4linux/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/video4linux/Makefile b/Documentation/video4linux/Makefile
> index d58101e..f19f38e 100644
> --- a/Documentation/video4linux/Makefile
> +++ b/Documentation/video4linux/Makefile
> @@ -1 +1,3 @@
> +ifneq ($(CONFIG_VIDEO_V4L2),)
>  obj-m := v4l2-pci-skeleton.o
> +endif
> 

The Kconfig file for this module says:

config VIDEO_PCI_SKELETON
	tristate "Skeleton PCI V4L2 driver"
	depends on PCI && BUILD_DOCSRC
	depends on VIDEO_V4L2 && VIDEOBUF2_CORE && VIDEOBUF2_MEMOPS

so it should already be limited to VIDEO_V4L2 being enabled.

What kernel or linux-next version did you see a problem with?

Please send the failing .config file so that I can check it.

Thanks.

-- 
~Randy

Re: [PATCH] Documentation/video4linux: don't build without CONFIG_VIDEO_V4L2

[Andrey Wagin]

2014-08-29 0:42 GMT+04:00 Randy Dunlap <rdunlap@infradead.org>:
> On 08/28/14 13:34, Andrey Vagin wrote:
>> Otherwise we get warnings:
>> WARNING: "vb2_ops_wait_finish" [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
>> WARNING: "vb2_ops_wait_prepare" [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
>> ...
>> WARNING: "video_unregister_device" [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
>>
>> Fixes: 8db5ab4b50fb ("Documentation: add makefiles for more targets")
>>
>> Cc: Peter Foley <pefoley2@pefoley.com>
>> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
>> Cc: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Andrey Vagin <avagin@openvz.org>
>> ---
>>  Documentation/video4linux/Makefile | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/video4linux/Makefile b/Documentation/video4linux/Makefile
>> index d58101e..f19f38e 100644
>> --- a/Documentation/video4linux/Makefile
>> +++ b/Documentation/video4linux/Makefile
>> @@ -1 +1,3 @@
>> +ifneq ($(CONFIG_VIDEO_V4L2),)
>>  obj-m := v4l2-pci-skeleton.o
>> +endif
>>
>
> The Kconfig file for this module says:
>
> config VIDEO_PCI_SKELETON
>         tristate "Skeleton PCI V4L2 driver"
>         depends on PCI && BUILD_DOCSRC
>         depends on VIDEO_V4L2 && VIDEOBUF2_CORE && VIDEOBUF2_MEMOPS
>
> so it should already be limited to VIDEO_V4L2 being enabled.
>
> What kernel or linux-next version did you see a problem with?

Eh, I'm late. It was fixed already

commit 81820f32ffaf393d9379c326d670257c63306a26
Author: Mark Brown <broonie@kernel.org>
Date:   Wed Aug 27 10:18:51 2014 +1000

    v4l2-pci-skeleton: Only build if PCI is available

Sorry for the noise.

>
> Please send the failing .config file so that I can check it.
>
> Thanks.
>
> --
> ~Randy