* [PATCH] media: pci: solo6x10: solo6x10-enc.c: Remove unused function
@ 2014-12-21 17:58 Rickard Strandqvist
2015-01-16 10:42 ` Hans Verkuil
2015-01-16 10:55 ` Hans Verkuil
0 siblings, 2 replies; 5+ messages in thread
From: Rickard Strandqvist @ 2014-12-21 17:58 UTC (permalink / raw)
To: Ismael Luceno, Mauro Carvalho Chehab
Cc: Rickard Strandqvist, linux-media, linux-kernel
Remove the function solo_s_jpeg_qp() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/media/pci/solo6x10/solo6x10-enc.c | 35 -----------------------------
drivers/media/pci/solo6x10/solo6x10.h | 2 --
2 files changed, 37 deletions(-)
diff --git a/drivers/media/pci/solo6x10/solo6x10-enc.c b/drivers/media/pci/solo6x10/solo6x10-enc.c
index d19c0ae..6b589b8 100644
--- a/drivers/media/pci/solo6x10/solo6x10-enc.c
+++ b/drivers/media/pci/solo6x10/solo6x10-enc.c
@@ -175,41 +175,6 @@ out:
return 0;
}
-/**
- * Set channel Quality Profile (0-3).
- */
-void solo_s_jpeg_qp(struct solo_dev *solo_dev, unsigned int ch,
- unsigned int qp)
-{
- unsigned long flags;
- unsigned int idx, reg;
-
- if ((ch > 31) || (qp > 3))
- return;
-
- if (solo_dev->type == SOLO_DEV_6010)
- return;
-
- if (ch < 16) {
- idx = 0;
- reg = SOLO_VE_JPEG_QP_CH_L;
- } else {
- ch -= 16;
- idx = 1;
- reg = SOLO_VE_JPEG_QP_CH_H;
- }
- ch *= 2;
-
- spin_lock_irqsave(&solo_dev->jpeg_qp_lock, flags);
-
- solo_dev->jpeg_qp[idx] &= ~(3 << ch);
- solo_dev->jpeg_qp[idx] |= (qp & 3) << ch;
-
- solo_reg_write(solo_dev, reg, solo_dev->jpeg_qp[idx]);
-
- spin_unlock_irqrestore(&solo_dev->jpeg_qp_lock, flags);
-}
-
int solo_g_jpeg_qp(struct solo_dev *solo_dev, unsigned int ch)
{
int idx;
diff --git a/drivers/media/pci/solo6x10/solo6x10.h b/drivers/media/pci/solo6x10/solo6x10.h
index 72017b7..ad5afc6 100644
--- a/drivers/media/pci/solo6x10/solo6x10.h
+++ b/drivers/media/pci/solo6x10/solo6x10.h
@@ -399,8 +399,6 @@ int solo_eeprom_write(struct solo_dev *solo_dev, int loc,
__be16 data);
/* JPEG Qp functions */
-void solo_s_jpeg_qp(struct solo_dev *solo_dev, unsigned int ch,
- unsigned int qp);
int solo_g_jpeg_qp(struct solo_dev *solo_dev, unsigned int ch);
#define CHK_FLAGS(v, flags) (((v) & (flags)) == (flags))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] media: pci: solo6x10: solo6x10-enc.c: Remove unused function
2014-12-21 17:58 [PATCH] media: pci: solo6x10: solo6x10-enc.c: Remove unused function Rickard Strandqvist
@ 2015-01-16 10:42 ` Hans Verkuil
2015-01-16 10:55 ` Hans Verkuil
1 sibling, 0 replies; 5+ messages in thread
From: Hans Verkuil @ 2015-01-16 10:42 UTC (permalink / raw)
To: Rickard Strandqvist, Ismael Luceno, Mauro Carvalho Chehab
Cc: linux-media, Andrey Utkin
Ismael, Andrey,
Can you take a look at this? Shouldn't solo_s_jpeg_qp() be hooked up to something?
Regards,
Hans
On 12/21/2014 06:58 PM, Rickard Strandqvist wrote:
> Remove the function solo_s_jpeg_qp() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/media/pci/solo6x10/solo6x10-enc.c | 35 -----------------------------
> drivers/media/pci/solo6x10/solo6x10.h | 2 --
> 2 files changed, 37 deletions(-)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-enc.c b/drivers/media/pci/solo6x10/solo6x10-enc.c
> index d19c0ae..6b589b8 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-enc.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-enc.c
> @@ -175,41 +175,6 @@ out:
> return 0;
> }
>
> -/**
> - * Set channel Quality Profile (0-3).
> - */
> -void solo_s_jpeg_qp(struct solo_dev *solo_dev, unsigned int ch,
> - unsigned int qp)
> -{
> - unsigned long flags;
> - unsigned int idx, reg;
> -
> - if ((ch > 31) || (qp > 3))
> - return;
> -
> - if (solo_dev->type == SOLO_DEV_6010)
> - return;
> -
> - if (ch < 16) {
> - idx = 0;
> - reg = SOLO_VE_JPEG_QP_CH_L;
> - } else {
> - ch -= 16;
> - idx = 1;
> - reg = SOLO_VE_JPEG_QP_CH_H;
> - }
> - ch *= 2;
> -
> - spin_lock_irqsave(&solo_dev->jpeg_qp_lock, flags);
> -
> - solo_dev->jpeg_qp[idx] &= ~(3 << ch);
> - solo_dev->jpeg_qp[idx] |= (qp & 3) << ch;
> -
> - solo_reg_write(solo_dev, reg, solo_dev->jpeg_qp[idx]);
> -
> - spin_unlock_irqrestore(&solo_dev->jpeg_qp_lock, flags);
> -}
> -
> int solo_g_jpeg_qp(struct solo_dev *solo_dev, unsigned int ch)
> {
> int idx;
> diff --git a/drivers/media/pci/solo6x10/solo6x10.h b/drivers/media/pci/solo6x10/solo6x10.h
> index 72017b7..ad5afc6 100644
> --- a/drivers/media/pci/solo6x10/solo6x10.h
> +++ b/drivers/media/pci/solo6x10/solo6x10.h
> @@ -399,8 +399,6 @@ int solo_eeprom_write(struct solo_dev *solo_dev, int loc,
> __be16 data);
>
> /* JPEG Qp functions */
> -void solo_s_jpeg_qp(struct solo_dev *solo_dev, unsigned int ch,
> - unsigned int qp);
> int solo_g_jpeg_qp(struct solo_dev *solo_dev, unsigned int ch);
>
> #define CHK_FLAGS(v, flags) (((v) & (flags)) == (flags))
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] media: pci: solo6x10: solo6x10-enc.c: Remove unused function
2014-12-21 17:58 [PATCH] media: pci: solo6x10: solo6x10-enc.c: Remove unused function Rickard Strandqvist
2015-01-16 10:42 ` Hans Verkuil
@ 2015-01-16 10:55 ` Hans Verkuil
2015-01-17 13:23 ` Ismael Luceno
1 sibling, 1 reply; 5+ messages in thread
From: Hans Verkuil @ 2015-01-16 10:55 UTC (permalink / raw)
To: Rickard Strandqvist, Ismael Luceno, Mauro Carvalho Chehab
Cc: linux-media, Andrey Utkin
(resent with correct email address for Ismael)
Ismael, Andrey,
Can you take a look at this? Shouldn't solo_s_jpeg_qp() be hooked up to something?
Regards,
Hans
On 12/21/2014 06:58 PM, Rickard Strandqvist wrote:
> Remove the function solo_s_jpeg_qp() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/media/pci/solo6x10/solo6x10-enc.c | 35 -----------------------------
> drivers/media/pci/solo6x10/solo6x10.h | 2 --
> 2 files changed, 37 deletions(-)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-enc.c b/drivers/media/pci/solo6x10/solo6x10-enc.c
> index d19c0ae..6b589b8 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-enc.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-enc.c
> @@ -175,41 +175,6 @@ out:
> return 0;
> }
>
> -/**
> - * Set channel Quality Profile (0-3).
> - */
> -void solo_s_jpeg_qp(struct solo_dev *solo_dev, unsigned int ch,
> - unsigned int qp)
> -{
> - unsigned long flags;
> - unsigned int idx, reg;
> -
> - if ((ch > 31) || (qp > 3))
> - return;
> -
> - if (solo_dev->type == SOLO_DEV_6010)
> - return;
> -
> - if (ch < 16) {
> - idx = 0;
> - reg = SOLO_VE_JPEG_QP_CH_L;
> - } else {
> - ch -= 16;
> - idx = 1;
> - reg = SOLO_VE_JPEG_QP_CH_H;
> - }
> - ch *= 2;
> -
> - spin_lock_irqsave(&solo_dev->jpeg_qp_lock, flags);
> -
> - solo_dev->jpeg_qp[idx] &= ~(3 << ch);
> - solo_dev->jpeg_qp[idx] |= (qp & 3) << ch;
> -
> - solo_reg_write(solo_dev, reg, solo_dev->jpeg_qp[idx]);
> -
> - spin_unlock_irqrestore(&solo_dev->jpeg_qp_lock, flags);
> -}
> -
> int solo_g_jpeg_qp(struct solo_dev *solo_dev, unsigned int ch)
> {
> int idx;
> diff --git a/drivers/media/pci/solo6x10/solo6x10.h b/drivers/media/pci/solo6x10/solo6x10.h
> index 72017b7..ad5afc6 100644
> --- a/drivers/media/pci/solo6x10/solo6x10.h
> +++ b/drivers/media/pci/solo6x10/solo6x10.h
> @@ -399,8 +399,6 @@ int solo_eeprom_write(struct solo_dev *solo_dev, int loc,
> __be16 data);
>
> /* JPEG Qp functions */
> -void solo_s_jpeg_qp(struct solo_dev *solo_dev, unsigned int ch,
> - unsigned int qp);
> int solo_g_jpeg_qp(struct solo_dev *solo_dev, unsigned int ch);
>
> #define CHK_FLAGS(v, flags) (((v) & (flags)) == (flags))
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] media: pci: solo6x10: solo6x10-enc.c: Remove unused function
2015-01-16 10:55 ` Hans Verkuil
@ 2015-01-17 13:23 ` Ismael Luceno
2015-01-17 13:27 ` Rickard Strandqvist
0 siblings, 1 reply; 5+ messages in thread
From: Ismael Luceno @ 2015-01-17 13:23 UTC (permalink / raw)
To: Hans Verkuil
Cc: Rickard Strandqvist, Mauro Carvalho Chehab, linux-media,
Andrey Utkin
On Fri, 16 Jan 2015 11:55:15 +0100
Hans Verkuil <hverkuil@xs4all.nl> wrote:
> (resent with correct email address for Ismael)
>
> Ismael, Andrey,
>
> Can you take a look at this? Shouldn't solo_s_jpeg_qp() be hooked up
> to something?
The feature was never implemented, so yes, and we should keep it around.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: pci: solo6x10: solo6x10-enc.c: Remove unused function
2015-01-17 13:23 ` Ismael Luceno
@ 2015-01-17 13:27 ` Rickard Strandqvist
0 siblings, 0 replies; 5+ messages in thread
From: Rickard Strandqvist @ 2015-01-17 13:27 UTC (permalink / raw)
To: Ismael Luceno
Cc: Hans Verkuil, Mauro Carvalho Chehab, linux-media, Andrey Utkin
2015-01-17 14:23 GMT+01:00 Ismael Luceno <ismael.luceno@gmail.com>:
> On Fri, 16 Jan 2015 11:55:15 +0100
> Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> (resent with correct email address for Ismael)
>>
>> Ismael, Andrey,
>>
>> Can you take a look at this? Shouldn't solo_s_jpeg_qp() be hooked up
>> to something?
>
> The feature was never implemented, so yes, and we should keep it around.
Hi
But maybe add a comment then?
Kind regards
Rickard Strandqvist
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-17 13:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-21 17:58 [PATCH] media: pci: solo6x10: solo6x10-enc.c: Remove unused function Rickard Strandqvist
2015-01-16 10:42 ` Hans Verkuil
2015-01-16 10:55 ` Hans Verkuil
2015-01-17 13:23 ` Ismael Luceno
2015-01-17 13:27 ` Rickard Strandqvist
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox