* [PATCH] media: i2c: adv7180: unregister the subdev in remove callback
@ 2015-02-26 18:19 Lad Prabhakar
2015-02-26 18:25 ` Lars-Peter Clausen
0 siblings, 1 reply; 3+ messages in thread
From: Lad Prabhakar @ 2015-02-26 18:19 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-media, Lad, Prabhakar
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
this patch makes sure we unregister the subdev by calling
v4l2_device_unregister_subdev() on remove callback.
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
drivers/media/i2c/adv7180.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
index b75878c..734d84a 100644
--- a/drivers/media/i2c/adv7180.c
+++ b/drivers/media/i2c/adv7180.c
@@ -1270,6 +1270,7 @@ static int adv7180_remove(struct i2c_client *client)
if (state->chip_info->flags & ADV7180_FLAG_MIPI_CSI2)
i2c_unregister_device(state->csi_client);
+ v4l2_device_unregister_subdev(sd);
mutex_destroy(&state->mutex);
return 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: i2c: adv7180: unregister the subdev in remove callback
2015-02-26 18:19 [PATCH] media: i2c: adv7180: unregister the subdev in remove callback Lad Prabhakar
@ 2015-02-26 18:25 ` Lars-Peter Clausen
2015-02-26 18:32 ` Lad, Prabhakar
0 siblings, 1 reply; 3+ messages in thread
From: Lars-Peter Clausen @ 2015-02-26 18:25 UTC (permalink / raw)
To: Lad Prabhakar; +Cc: linux-media
On 02/26/2015 07:19 PM, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> this patch makes sure we unregister the subdev by calling
> v4l2_device_unregister_subdev() on remove callback.
This was just removed a while ago, see commit 632f2b0db9da ("[media]
adv7180: Remove duplicate unregister call")[1].
- Lars
[1]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=632f2b0db9dabbaa5835b50a75a3a1639d6f6f38
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: i2c: adv7180: unregister the subdev in remove callback
2015-02-26 18:25 ` Lars-Peter Clausen
@ 2015-02-26 18:32 ` Lad, Prabhakar
0 siblings, 0 replies; 3+ messages in thread
From: Lad, Prabhakar @ 2015-02-26 18:32 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-media
Hi Lars,
On Thu, Feb 26, 2015 at 6:25 PM, Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 02/26/2015 07:19 PM, Lad Prabhakar wrote:
>>
>> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>>
>> this patch makes sure we unregister the subdev by calling
>> v4l2_device_unregister_subdev() on remove callback.
>
>
> This was just removed a while ago, see commit 632f2b0db9da ("[media]
> adv7180: Remove duplicate unregister call")[1].
>
Sorry for the noise, I missed the path
v4l2_async_unregister_subdev --> v4l2_async_cleanup -->
v4l2_device_unregister_subdev()
Cheers,
--Prabhakar Lad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-26 18:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-26 18:19 [PATCH] media: i2c: adv7180: unregister the subdev in remove callback Lad Prabhakar
2015-02-26 18:25 ` Lars-Peter Clausen
2015-02-26 18:32 ` Lad, Prabhakar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox