* [PATCH 1/1] Fix DVBsky rc-keymap
@ 2015-03-09 22:02 Dirk Nehring
2015-03-10 7:53 ` Antti Palosaari
0 siblings, 1 reply; 5+ messages in thread
From: Dirk Nehring @ 2015-03-09 22:02 UTC (permalink / raw)
To: linux-media; +Cc: nibble.max, Dirk Nehring
Signed-off-by: Dirk Nehring <dnehring@gmx.net>
---
drivers/media/rc/keymaps/rc-dvbsky.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/rc/keymaps/rc-dvbsky.c b/drivers/media/rc/keymaps/rc-dvbsky.c
index c5115a1..b942b16 100644
--- a/drivers/media/rc/keymaps/rc-dvbsky.c
+++ b/drivers/media/rc/keymaps/rc-dvbsky.c
@@ -33,16 +33,16 @@ static struct rc_map_table rc5_dvbsky[] = {
{ 0x000b, KEY_STOP },
{ 0x000c, KEY_EXIT },
{ 0x000e, KEY_CAMERA }, /*Snap shot*/
- { 0x000f, KEY_SUBTITLE }, /*PIP*/
- { 0x0010, KEY_VOLUMEUP },
- { 0x0011, KEY_VOLUMEDOWN },
+ { 0x000f, KEY_TV2 }, /*PIP*/
+ { 0x0010, KEY_RIGHT },
+ { 0x0011, KEY_LEFT },
{ 0x0012, KEY_FAVORITES },
- { 0x0013, KEY_LIST }, /*Info*/
+ { 0x0013, KEY_INFO },
{ 0x0016, KEY_PAUSE },
{ 0x0017, KEY_PLAY },
{ 0x001f, KEY_RECORD },
- { 0x0020, KEY_CHANNELDOWN },
- { 0x0021, KEY_CHANNELUP },
+ { 0x0020, KEY_UP },
+ { 0x0021, KEY_DOWN },
{ 0x0025, KEY_POWER2 },
{ 0x0026, KEY_REWIND },
{ 0x0027, KEY_FASTFORWARD },
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] Fix DVBsky rc-keymap
2015-03-09 22:02 [PATCH 1/1] Fix DVBsky rc-keymap Dirk Nehring
@ 2015-03-10 7:53 ` Antti Palosaari
2015-03-10 8:16 ` Dirk Nehring
0 siblings, 1 reply; 5+ messages in thread
From: Antti Palosaari @ 2015-03-10 7:53 UTC (permalink / raw)
To: Dirk Nehring, linux-media; +Cc: nibble.max
On 03/10/2015 12:02 AM, Dirk Nehring wrote:
> Signed-off-by: Dirk Nehring <dnehring@gmx.net>
> ---
> drivers/media/rc/keymaps/rc-dvbsky.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/rc/keymaps/rc-dvbsky.c b/drivers/media/rc/keymaps/rc-dvbsky.c
> index c5115a1..b942b16 100644
> --- a/drivers/media/rc/keymaps/rc-dvbsky.c
> +++ b/drivers/media/rc/keymaps/rc-dvbsky.c
> @@ -33,16 +33,16 @@ static struct rc_map_table rc5_dvbsky[] = {
> { 0x000b, KEY_STOP },
> { 0x000c, KEY_EXIT },
> { 0x000e, KEY_CAMERA }, /*Snap shot*/
> - { 0x000f, KEY_SUBTITLE }, /*PIP*/
> - { 0x0010, KEY_VOLUMEUP },
> - { 0x0011, KEY_VOLUMEDOWN },
> + { 0x000f, KEY_TV2 }, /*PIP*/
I don't know what kind of layout there really is, but according to
comment that button is PIP which should be KEY_NEW. I wonder if you
mapped those UP/DOWN buttons also badly...
http://linuxtv.org/wiki/index.php/Remote_Controllers
> + { 0x0010, KEY_RIGHT },
> + { 0x0011, KEY_LEFT },
> { 0x0012, KEY_FAVORITES },
> - { 0x0013, KEY_LIST }, /*Info*/
> + { 0x0013, KEY_INFO },
> { 0x0016, KEY_PAUSE },
> { 0x0017, KEY_PLAY },
> { 0x001f, KEY_RECORD },
> - { 0x0020, KEY_CHANNELDOWN },
> - { 0x0021, KEY_CHANNELUP },
> + { 0x0020, KEY_UP },
> + { 0x0021, KEY_DOWN },
> { 0x0025, KEY_POWER2 },
> { 0x0026, KEY_REWIND },
> { 0x0027, KEY_FASTFORWARD },
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] Fix DVBsky rc-keymap
2015-03-10 7:53 ` Antti Palosaari
@ 2015-03-10 8:16 ` Dirk Nehring
0 siblings, 0 replies; 5+ messages in thread
From: Dirk Nehring @ 2015-03-10 8:16 UTC (permalink / raw)
To: Antti Palosaari; +Cc: linux-media, nibble.max
On Tue, Mar 10, 2015 at 09:53:04AM +0200, Antti Palosaari wrote:
>
>
> On 03/10/2015 12:02 AM, Dirk Nehring wrote:
> >Signed-off-by: Dirk Nehring <dnehring@gmx.net>
> >---
> > drivers/media/rc/keymaps/rc-dvbsky.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> >diff --git a/drivers/media/rc/keymaps/rc-dvbsky.c b/drivers/media/rc/keymaps/rc-dvbsky.c
> >index c5115a1..b942b16 100644
> >--- a/drivers/media/rc/keymaps/rc-dvbsky.c
> >+++ b/drivers/media/rc/keymaps/rc-dvbsky.c
> >@@ -33,16 +33,16 @@ static struct rc_map_table rc5_dvbsky[] = {
> > { 0x000b, KEY_STOP },
> > { 0x000c, KEY_EXIT },
> > { 0x000e, KEY_CAMERA }, /*Snap shot*/
> >- { 0x000f, KEY_SUBTITLE }, /*PIP*/
> >- { 0x0010, KEY_VOLUMEUP },
> >- { 0x0011, KEY_VOLUMEDOWN },
> >+ { 0x000f, KEY_TV2 }, /*PIP*/
>
> I don't know what kind of layout there really is, but according to
> comment that button is PIP which should be KEY_NEW. I wonder if you
> mapped those UP/DOWN buttons also badly...
>
> http://linuxtv.org/wiki/index.php/Remote_Controllers
OK, KEY_NEW should be better (I just orientated on other rc
keymaps). The UP/DOWN buttons are correct, the DVBsky rc has no channel
up/down buttons.
Best regards,
Dirk
>
>
>
> >+ { 0x0010, KEY_RIGHT },
> >+ { 0x0011, KEY_LEFT },
> > { 0x0012, KEY_FAVORITES },
> >- { 0x0013, KEY_LIST }, /*Info*/
> >+ { 0x0013, KEY_INFO },
> > { 0x0016, KEY_PAUSE },
> > { 0x0017, KEY_PLAY },
> > { 0x001f, KEY_RECORD },
> >- { 0x0020, KEY_CHANNELDOWN },
> >- { 0x0021, KEY_CHANNELUP },
> >+ { 0x0020, KEY_UP },
> >+ { 0x0021, KEY_DOWN },
> > { 0x0025, KEY_POWER2 },
> > { 0x0026, KEY_REWIND },
> > { 0x0027, KEY_FASTFORWARD },
> >
>
> --
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] Fix DVBsky rc-keymap
@ 2015-03-10 1:48 Nibble Max
2015-03-10 8:04 ` Dirk Nehring
0 siblings, 1 reply; 5+ messages in thread
From: Nibble Max @ 2015-03-10 1:48 UTC (permalink / raw)
To: Dirk Nehring; +Cc: linux-media
Hello,
Mapping VOLUME and CHANNEL keys to the general ones will break some tv softwares remote control functions.
Best Regards,
Max
On 2015-03-10 06:05:02, Dirk Nehring <dnehring@gmx.net> wrote:
>Signed-off-by: Dirk Nehring <dnehring@gmx.net>
>---
> drivers/media/rc/keymaps/rc-dvbsky.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/media/rc/keymaps/rc-dvbsky.c b/drivers/media/rc/keymaps/rc-dvbsky.c
>index c5115a1..b942b16 100644
>--- a/drivers/media/rc/keymaps/rc-dvbsky.c
>+++ b/drivers/media/rc/keymaps/rc-dvbsky.c
>@@ -33,16 +33,16 @@ static struct rc_map_table rc5_dvbsky[] = {
> { 0x000b, KEY_STOP },
> { 0x000c, KEY_EXIT },
> { 0x000e, KEY_CAMERA }, /*Snap shot*/
>- { 0x000f, KEY_SUBTITLE }, /*PIP*/
>- { 0x0010, KEY_VOLUMEUP },
>- { 0x0011, KEY_VOLUMEDOWN },
>+ { 0x000f, KEY_TV2 }, /*PIP*/
>+ { 0x0010, KEY_RIGHT },
>+ { 0x0011, KEY_LEFT },
> { 0x0012, KEY_FAVORITES },
>- { 0x0013, KEY_LIST }, /*Info*/
>+ { 0x0013, KEY_INFO },
> { 0x0016, KEY_PAUSE },
> { 0x0017, KEY_PLAY },
> { 0x001f, KEY_RECORD },
>- { 0x0020, KEY_CHANNELDOWN },
>- { 0x0021, KEY_CHANNELUP },
>+ { 0x0020, KEY_UP },
>+ { 0x0021, KEY_DOWN },
> { 0x0025, KEY_POWER2 },
> { 0x0026, KEY_REWIND },
> { 0x0027, KEY_FASTFORWARD },
>--
>2.1.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] Fix DVBsky rc-keymap
2015-03-10 1:48 Nibble Max
@ 2015-03-10 8:04 ` Dirk Nehring
0 siblings, 0 replies; 5+ messages in thread
From: Dirk Nehring @ 2015-03-10 8:04 UTC (permalink / raw)
To: Nibble Max; +Cc: linux-media
On Tue, Mar 10, 2015 at 09:48:33AM +0800, Nibble Max wrote:
> Hello,
>
> Mapping VOLUME and CHANNEL keys to the general ones will break some tv softwares remote control functions.
The remote control has no volume and channel control, I would leave it
to the general mapping. Tested successfully with vdr 2.2.0.
Best regards,
Dirk
>
> Best Regards,
> Max
>
> On 2015-03-10 06:05:02, Dirk Nehring <dnehring@gmx.net> wrote:
> >Signed-off-by: Dirk Nehring <dnehring@gmx.net>
> >---
> > drivers/media/rc/keymaps/rc-dvbsky.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> >diff --git a/drivers/media/rc/keymaps/rc-dvbsky.c b/drivers/media/rc/keymaps/rc-dvbsky.c
> >index c5115a1..b942b16 100644
> >--- a/drivers/media/rc/keymaps/rc-dvbsky.c
> >+++ b/drivers/media/rc/keymaps/rc-dvbsky.c
> >@@ -33,16 +33,16 @@ static struct rc_map_table rc5_dvbsky[] = {
> > { 0x000b, KEY_STOP },
> > { 0x000c, KEY_EXIT },
> > { 0x000e, KEY_CAMERA }, /*Snap shot*/
> >- { 0x000f, KEY_SUBTITLE }, /*PIP*/
> >- { 0x0010, KEY_VOLUMEUP },
> >- { 0x0011, KEY_VOLUMEDOWN },
> >+ { 0x000f, KEY_TV2 }, /*PIP*/
> >+ { 0x0010, KEY_RIGHT },
> >+ { 0x0011, KEY_LEFT },
> > { 0x0012, KEY_FAVORITES },
> >- { 0x0013, KEY_LIST }, /*Info*/
> >+ { 0x0013, KEY_INFO },
> > { 0x0016, KEY_PAUSE },
> > { 0x0017, KEY_PLAY },
> > { 0x001f, KEY_RECORD },
> >- { 0x0020, KEY_CHANNELDOWN },
> >- { 0x0021, KEY_CHANNELUP },
> >+ { 0x0020, KEY_UP },
> >+ { 0x0021, KEY_DOWN },
> > { 0x0025, KEY_POWER2 },
> > { 0x0026, KEY_REWIND },
> > { 0x0027, KEY_FASTFORWARD },
> >--
> >2.1.0
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-03-10 8:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-09 22:02 [PATCH 1/1] Fix DVBsky rc-keymap Dirk Nehring
2015-03-10 7:53 ` Antti Palosaari
2015-03-10 8:16 ` Dirk Nehring
-- strict thread matches above, loose matches on Subject: below --
2015-03-10 1:48 Nibble Max
2015-03-10 8:04 ` Dirk Nehring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox