Linux Media Controller development
 help / color / mirror / Atom feed
* [PATCH] v4l2-pci-skeleton.c: forgot to update v4l2_match_dv_timings call
@ 2015-11-13 14:01 Hans Verkuil
  2015-11-13 14:52 ` kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2015-11-13 14:01 UTC (permalink / raw)
  To: Linux Media Mailing List

Add missing new argument to v4l2_match_dv_timings() in this skeleton driver.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>

diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c
index 95ae828..1c8b102 100644
--- a/Documentation/video4linux/v4l2-pci-skeleton.c
+++ b/Documentation/video4linux/v4l2-pci-skeleton.c
@@ -509,7 +509,7 @@ static int skeleton_s_dv_timings(struct file *file, void *_fh,
 		return -EINVAL;
 
 	/* Return 0 if the new timings are the same as the current timings. */
-	if (v4l2_match_dv_timings(timings, &skel->timings, 0))
+	if (v4l2_match_dv_timings(timings, &skel->timings, 0, false))
 		return 0;
 
 	/*

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] v4l2-pci-skeleton.c: forgot to update v4l2_match_dv_timings call
  2015-11-13 14:01 [PATCH] v4l2-pci-skeleton.c: forgot to update v4l2_match_dv_timings call Hans Verkuil
@ 2015-11-13 14:52 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-11-13 14:52 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: kbuild-all, Linux Media Mailing List

[-- Attachment #1: Type: text/plain, Size: 1550 bytes --]

Hi Hans,

[auto build test ERROR on v4.3-rc7]
[also build test ERROR on next-20151113]

url:    https://github.com/0day-ci/linux/commits/Hans-Verkuil/v4l2-pci-skeleton-c-forgot-to-update-v4l2_match_dv_timings-call/20151113-220325
config: i386-randconfig-s0-201545 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   Documentation/video4linux/v4l2-pci-skeleton.c: In function 'skeleton_s_dv_timings':
>> Documentation/video4linux/v4l2-pci-skeleton.c:510:6: error: too many arguments to function 'v4l2_match_dv_timings'
     if (v4l2_match_dv_timings(timings, &skel->timings, 0, false))
         ^
   In file included from Documentation/video4linux/v4l2-pci-skeleton.c:37:0:
   include/media/v4l2-dv-timings.h:113:6: note: declared here
    bool v4l2_match_dv_timings(const struct v4l2_dv_timings *measured,
         ^

vim +/v4l2_match_dv_timings +510 Documentation/video4linux/v4l2-pci-skeleton.c

   504		/* Check if the timings are part of the CEA-861 timings. */
   505		if (!v4l2_find_dv_timings_cap(timings, &skel_timings_cap,
   506					      0, NULL, NULL))
   507			return -EINVAL;
   508	
   509		/* Return 0 if the new timings are the same as the current timings. */
 > 510		if (v4l2_match_dv_timings(timings, &skel->timings, 0, false))
   511			return 0;
   512	
   513		/*

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 22975 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-13 14:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-13 14:01 [PATCH] v4l2-pci-skeleton.c: forgot to update v4l2_match_dv_timings call Hans Verkuil
2015-11-13 14:52 ` kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox