Re: [PATCH 1/1] media: Don't hide I²C or SPI drivers by default

[Hans Verkuil <hverkuil+cisco@kernel.org>]

On 18/09/2026 10:17, Sakari Ailus wrote:
> MEDIA_HIDE_ANCILLARY_SUBDRV Kconfig option was intended for working with
> sub-device and other helper driver autoselection in cases where the
> required drivers are known, e.g. for PCI cards where all the related
> components are mounted. This option, however, applied to e.g. all camera
> sensor and lens VCM drivers that are generally present in systems without
> being mounted on such a card. This leads to easily omitting required
> drivers.
> 
> Drop the MEDIA_HIDE_ANCILLARY_SUBDRV for I²C and SPI devices.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Acked-by: Hans Verkuil <hverkuil+cisco@kernel.org>

Regards,

	Hans

> ---
>  drivers/media/i2c/Kconfig | 11 +----------
>  drivers/media/spi/Kconfig |  4 ----
>  2 files changed, 1 insertion(+), 14 deletions(-)
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 4d9946479160..9b28e91b8a67 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -1010,14 +1010,12 @@ endmenu
>  # V4L2 I2C drivers that aren't related with Camera support
>  #
>  
> -comment "audio, video and radio I2C drivers auto-selected by 'Autoselect ancillary drivers'"
> -	depends on MEDIA_HIDE_ANCILLARY_SUBDRV
> +comment "audio, video and radio I2C drivers"
>  #
>  # Encoder / Decoder module configuration
>  #
>  
>  menu "Audio decoders, processors and mixers"
> -	visible if !MEDIA_HIDE_ANCILLARY_SUBDRV
>  
>  config VIDEO_CS3308
>  	tristate "Cirrus Logic CS3308 audio ADC"
> @@ -1180,7 +1178,6 @@ config VIDEO_WM8775
>  endmenu
>  
>  menu "RDS decoders"
> -	visible if !MEDIA_HIDE_ANCILLARY_SUBDRV
>  
>  config VIDEO_SAA6588
>  	tristate "SAA6588 Radio Chip RDS decoder support"
> @@ -1197,7 +1194,6 @@ config VIDEO_SAA6588
>  endmenu
>  
>  menu "Video decoders"
> -	visible if !MEDIA_HIDE_ANCILLARY_SUBDRV
>  
>  config VIDEO_ADV7180
>  	tristate "Analog Devices ADV7180 decoder"
> @@ -1557,7 +1553,6 @@ source "drivers/media/i2c/cx25840/Kconfig"
>  endmenu
>  
>  menu "Video encoders"
> -	visible if !MEDIA_HIDE_ANCILLARY_SUBDRV
>  
>  config VIDEO_ADV7170
>  	tristate "Analog Devices ADV7170 video encoder"
> @@ -1656,7 +1651,6 @@ config VIDEO_THS8200
>  endmenu
>  
>  menu "Video improvement chips"
> -	visible if !MEDIA_HIDE_ANCILLARY_SUBDRV
>  
>  config VIDEO_UPD64031A
>  	tristate "NEC Electronics uPD64031A Ghost Reduction"
> @@ -1685,7 +1679,6 @@ config VIDEO_UPD64083
>  endmenu
>  
>  menu "Audio/Video compression chips"
> -	visible if !MEDIA_HIDE_ANCILLARY_SUBDRV
>  
>  config VIDEO_SAA6752HS
>  	tristate "Philips SAA6752HS MPEG-2 Audio/Video Encoder"
> @@ -1701,7 +1694,6 @@ config VIDEO_SAA6752HS
>  endmenu
>  
>  menu "SDR tuner chips"
> -	visible if !MEDIA_HIDE_ANCILLARY_SUBDRV
>  
>  config SDR_MAX2175
>  	tristate "Maxim 2175 RF to Bits tuner"
> @@ -1718,7 +1710,6 @@ config SDR_MAX2175
>  endmenu
>  
>  menu "Miscellaneous helper chips"
> -	visible if !MEDIA_HIDE_ANCILLARY_SUBDRV
>  
>  source "drivers/media/i2c/cvs/Kconfig"
>  
> diff --git a/drivers/media/spi/Kconfig b/drivers/media/spi/Kconfig
> index 4656afae5bb4..da3e225d420d 100644
> --- a/drivers/media/spi/Kconfig
> +++ b/drivers/media/spi/Kconfig
> @@ -1,15 +1,11 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  if VIDEO_DEV && SPI
>  
> -comment "SPI I2C drivers auto-selected by 'Autoselect ancillary drivers'"
> -	depends on MEDIA_HIDE_ANCILLARY_SUBDRV && SPI
> -
>  menu "Media SPI Adapters"
>  
>  config CXD2880_SPI_DRV
>  	tristate "Sony CXD2880 SPI support"
>  	depends on DVB_CORE && SPI
> -	default m if !MEDIA_SUBDRV_AUTOSELECT
>  	help
>  	  Choose if you would like to have SPI interface support for Sony CXD2880.
>  
> 
> base-commit: aedd77ea8168f00687c1248cdf115071e869cf93