Re: [PATCH 1/1] media: Don't hide I²C or SPI drivers by default

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Thorsten,

On Mon, Sep 21, 2026 at 09:16:12AM +0200, Thorsten Leemhuis wrote:
> On 9/21/26 08:54, Sakari Ailus wrote:
> > On Sun, Sep 20, 2026 at 10:03:47AM +0800, Junjie Cao wrote:
> >> On Sat, Sep 19, 2026 at 09:10:18AM +0200, Thorsten Leemhuis wrote:
> >>> Also wondering if the "olddefconfig" case on Arch was tested to ensure
> >>> we prevent more people running into problems that Junjie's fix linked to
> >>
> >> Ran it: this patch on its base-commit, Arch's
> >> config.x86_64 (7.2.4.arch1):
> >>
> >>   olddefconfig, before: no VIDEO_INTEL_CVS line
> >>   olddefconfig, after:  # CONFIG_VIDEO_INTEL_CVS is not set
> >>
> >> The option has no default, so olddefconfig leaves it
> >> off. With the patch, oldconfig prompts for it as (NEW)
> >> and listnewconfig lists it.
> > 
> > Generally drivers are unselected by default and cvs is no exception.
> 
> Yup, sure, but it seems we here due to some oddity (details don't matter
> much) ran into a situation that users perceive as regression (which
> matters a lot).

It was really about this option being hidden by default so you couldn't
even select it. (It's no wonder: I had enabled EXPERT in my own .config,
quite possibly more than 10 years ago, to select things without much
thinking about it!)

> > What I think we could possibly do is to add to cvs Kconfig:
> > 
> > 	default VIDEO_INTEL_IPU6
> > 
> > As the cvs driver is (at least right now) used with ipu6 driver only.
> 
> Due to what I wrote above I'd say: this sounds like a good solution that
> has no significant downsides -- and avoids a problem for everyone that
> manually configures their kernel in the future, which is a good thing,
> too. And we can easily drop the default later if there is a strong need
> (and then likely should add a hint to the help text which other symbols
> are needed in case it doesn't have one already; didn't check)

I can post a patch. I think what also made a difference was that the CVS
chip was in a different menu because it's an I²C device.

-- 
Regards,

Sakari Ailus