Re: [PATCHv2 15/19] media: samsung: s3c-camif: drop unnecessary vb2_queue_release

[Hans Verkuil <hverkuil+cisco@kernel.org>]

On 27/07/2026 15:13, Hans Verkuil wrote:
> The vb2_queue_release() function should not be called directly from a
> driver. Leave that to the helper functions.
> 
> Use _vb2_fop_release instead of vb2_queue_release/v4l2_fh_release.
> 
> No need to call camif_stop_capture: _vb2_fop_release will call
> the stop_streaming op if streaming is in progress, and that op
> calls camif_stop_capture.
> 
> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
> Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
> ---
>  drivers/media/platform/samsung/s3c-camif/camif-capture.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/media/platform/samsung/s3c-camif/camif-capture.c b/drivers/media/platform/samsung/s3c-camif/camif-capture.c
> index ed1a1d693293..3cbf58b2128e 100644
> --- a/drivers/media/platform/samsung/s3c-camif/camif-capture.c
> +++ b/drivers/media/platform/samsung/s3c-camif/camif-capture.c
> @@ -572,16 +572,11 @@ static int s3c_camif_close(struct file *file)
>  
>  	mutex_lock(&camif->lock);
>  
> -	if (vp->owner == file_to_v4l2_fh(file)) {
> -		camif_stop_capture(vp);
> -		vb2_queue_release(&vp->vb_queue);
> -		vp->owner = NULL;
> -	}
> +	ret = _vb2_fop_release(file, NULL);
>  
>  	sensor_set_power(camif, 0);
>  
>  	pm_runtime_put(camif->dev);
> -	ret = v4l2_fh_release(file);
>  
>  	mutex_unlock(&camif->lock);
>  	return ret;

I'm dropping this patch from the series: this driver doesn't set vdev->queue, which is
what _vb2_fop_release relies on.

It's probably just a matter of setting that field, but it needs a bit more research
than I have time for now.

Regards,

	Hans