From: Jai Luthra <jai.luthra@linux.dev>
To: Hans Verkuil <hverkuil+cisco@kernel.org>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCHv2 16/19] media: ti: j721e-csi2rx: use vb2_video_unregister_device
Date: Tue, 28 Jul 2026 11:30:08 +0530 [thread overview]
Message-ID: <amhFRkfFmcn8G1sW@freya> (raw)
In-Reply-To: <afdd67b43f0bed88d897927c28c6f478106f2011.1785157986.git.hverkuil+cisco@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
Hi Hans,
Thank you for the patch.
On Mon, Jul 27, 2026 at 03:13:03PM +0200, Hans Verkuil wrote:
> The vb2_queue_release() function should not be called directly from a
> driver. Leave that to the helper functions.
>
> Replace the vb2_queue_release/video_unregister_device pair by
> a single vb2_video_unregister_device call.
>
> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
> Cc: Jai Luthra <jai.luthra@linux.dev>
Acked-by: Jai Luthra <jai.luthra@linux.dev>
Thanks,
Jai
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-07-28 6:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 13:12 [PATCHv2 00/19] media: clean up unnecessary vb2_queue_release calls Hans Verkuil
2026-07-27 13:12 ` [PATCHv2 01/19] media: videobuf2-v4l2.h: improve vb2_queue_release() documentation Hans Verkuil
2026-07-27 13:12 ` [PATCHv2 02/19] media: pci: hws: drop call to vb2_queue_release Hans Verkuil
2026-07-27 13:12 ` [PATCHv2 03/19] media: pci: ipu6: drop calls to vb2_video_unregister_device and vb2_queue_release Hans Verkuil
2026-07-27 13:12 ` [PATCHv2 04/19] media: pci: zoran: use vb2_video_unregister_device Hans Verkuil
2026-07-27 13:12 ` [PATCHv2 05/19] media: platform: amd: isp4: drop vb2_queue_release calls Hans Verkuil
2026-07-27 13:12 ` [PATCHv2 06/19] media: amlogic: c3: isp: " Hans Verkuil
2026-07-27 13:12 ` [PATCHv2 07/19] media: amphion: drop unnecessary vb2_queue_release call Hans Verkuil
2026-07-27 15:57 ` Frank Li
2026-07-28 1:30 ` [EXT] " Ming Qian
2026-07-27 13:12 ` [PATCHv2 08/19] media: arm: mali-c55: drop unnecessary vb2_queue_release calls Hans Verkuil
2026-07-27 13:12 ` [PATCHv2 09/19] media: imagination: e5010-jpeg-enc: drop vb2_queue_release Hans Verkuil
2026-07-27 13:12 ` [PATCHv2 10/19] media: nuvoton: drop unnecessary vb2_queue_release calls Hans Verkuil
2026-07-27 13:12 ` [PATCHv2 11/19] media: nxp: imx7-media-csi: use _vb2_fop_release/vb2_video_unregister_device Hans Verkuil
2026-07-27 15:56 ` Frank Li
2026-07-27 13:12 ` [PATCHv2 12/19] media: raspberrypi: pisp_be: use vb2_video_unregister_device Hans Verkuil
2026-07-27 13:13 ` [PATCHv2 13/19] media: renesas: rzv2h-cru: " Hans Verkuil
2026-07-27 13:13 ` [PATCHv2 14/19] media: renesas: rzv2h-ivc: drop unnecessary vb2_queue_release calls Hans Verkuil
2026-07-27 13:13 ` [PATCHv2 15/19] media: samsung: s3c-camif: drop unnecessary vb2_queue_release Hans Verkuil
2026-07-27 13:13 ` [PATCHv2 16/19] media: ti: j721e-csi2rx: use vb2_video_unregister_device Hans Verkuil
2026-07-28 6:00 ` Jai Luthra [this message]
2026-07-27 13:13 ` [PATCHv2 17/19] staging: media: imx: drop vb2_queue_release call Hans Verkuil
2026-07-27 15:55 ` Frank Li
2026-07-27 13:13 ` [PATCHv2 18/19] staging: media: ipu7: drop unnecessary cleanup calls Hans Verkuil
2026-07-27 13:13 ` [PATCHv2 19/19] media: renesas: rzg2l-cru: drop unnecessary vb2_queue_release Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amhFRkfFmcn8G1sW@freya \
--to=jai.luthra@linux.dev \
--cc=hverkuil+cisco@kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox