From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Petr Cvek <petr.cvek@tul.cz>, Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 2/4] [media] pxa_camera: Fix incorrect test in the image size generation
Date: Tue, 02 May 2017 16:43:48 +0200 [thread overview]
Message-ID: <871ss71fq3.fsf@belgarion.home> (raw)
In-Reply-To: <1e599794-36e7-3b26-8bb0-57c5b31d3956@tul.cz> (Petr Cvek's message of "Mon, 1 May 2017 06:21:10 +0200")
Petr Cvek <petr.cvek@tul.cz> writes:
> During the transfer from the soc_camera a test in pxa_mbus_image_size()
> got removed. Without it any PXA_MBUS_LAYOUT_PACKED format causes either
> the return of a wrong value (PXA_MBUS_PACKING_2X8_PADHI doubles
> the correct value) or EINVAL (PXA_MBUS_PACKING_NONE and
> PXA_MBUS_PACKING_EXTEND16). This was observed in an error from the ffmpeg
> (for some of the YUYV subvariants).
>
> This patch re-adds the same test as in soc_camera version.
>
> Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
Did you test that with YUV422P format ?
If yes, then you can have my ack.
And you should add Hans to the reviewers list, it's his call ultimately, and his
tree which should carry it on.
Cheers.
--
Robert
next prev parent reply other threads:[~2017-05-02 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1493612057.git.petr.cvek@tul.cz>
2017-05-01 4:20 ` [PATCH 1/4] [media] pxa_camera: Add remaining Bayer 8 formats Petr Cvek
2017-05-02 14:37 ` Robert Jarzmik
2017-05-01 4:21 ` [PATCH 2/4] [media] pxa_camera: Fix incorrect test in the image size generation Petr Cvek
2017-05-02 14:43 ` Robert Jarzmik [this message]
2017-05-03 5:39 ` Petr Cvek
2017-05-05 3:30 ` Petr Cvek
2017-05-01 4:21 ` [PATCH 3/4] [media] pxa_camera: Add (un)subscribe_event ioctl Petr Cvek
2017-05-02 14:46 ` Robert Jarzmik
2017-05-01 4:21 ` [PATCH 4/4] [media] pxa_camera: Fix a call with an uninitialized device pointer Petr Cvek
2017-05-02 14:53 ` Robert Jarzmik
2017-05-05 3:14 ` Petr Cvek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ss71fq3.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=petr.cvek@tul.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox