From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Petr Cvek <petr.cvek@tul.cz>, Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 3/4] [media] pxa_camera: Add (un)subscribe_event ioctl
Date: Tue, 02 May 2017 16:46:52 +0200 [thread overview]
Message-ID: <87wp9zz57n.fsf@belgarion.home> (raw)
In-Reply-To: <0c2bf711-dbdf-f384-fc6f-4e7f5ed964b1@tul.cz> (Petr Cvek's message of "Mon, 1 May 2017 06:21:29 +0200")
Petr Cvek <petr.cvek@tul.cz> writes:
> The v4l2-compliance complains about nonexistent vidioc_subscribe_event
> and vidioc_unsubscribe_event calls. Add them to fix the complaints.
>
> Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
Don't know on that one, let others on the mailing list comment, I'm not familiar
with the event interface of v4l2.
Cheers.
--
Robert
> ---
> drivers/media/platform/pxa_camera.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c
> index f71e7e0a652b..79fd7269d1e6 100644
> --- a/drivers/media/platform/pxa_camera.c
> +++ b/drivers/media/platform/pxa_camera.c
> @@ -37,7 +37,9 @@
> #include <media/v4l2-async.h>
> #include <media/v4l2-clk.h>
> #include <media/v4l2-common.h>
> +#include <media/v4l2-ctrls.h>
> #include <media/v4l2-device.h>
> +#include <media/v4l2-event.h>
> #include <media/v4l2-ioctl.h>
> #include <media/v4l2-of.h>
>
> @@ -2089,6 +2091,8 @@ static const struct v4l2_ioctl_ops pxa_camera_ioctl_ops = {
> .vidioc_g_register = pxac_vidioc_g_register,
> .vidioc_s_register = pxac_vidioc_s_register,
> #endif
> + .vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
> + .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
> };
>
> static struct v4l2_clk_ops pxa_camera_mclk_ops = {
next prev parent reply other threads:[~2017-05-02 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1493612057.git.petr.cvek@tul.cz>
2017-05-01 4:20 ` [PATCH 1/4] [media] pxa_camera: Add remaining Bayer 8 formats Petr Cvek
2017-05-02 14:37 ` Robert Jarzmik
2017-05-01 4:21 ` [PATCH 2/4] [media] pxa_camera: Fix incorrect test in the image size generation Petr Cvek
2017-05-02 14:43 ` Robert Jarzmik
2017-05-03 5:39 ` Petr Cvek
2017-05-05 3:30 ` Petr Cvek
2017-05-01 4:21 ` [PATCH 3/4] [media] pxa_camera: Add (un)subscribe_event ioctl Petr Cvek
2017-05-02 14:46 ` Robert Jarzmik [this message]
2017-05-01 4:21 ` [PATCH 4/4] [media] pxa_camera: Fix a call with an uninitialized device pointer Petr Cvek
2017-05-02 14:53 ` Robert Jarzmik
2017-05-05 3:14 ` Petr Cvek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp9zz57n.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=petr.cvek@tul.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox