From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Chuhong Yuan <hslester96@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] media: pxa_camera: remove an impossible condition
Date: Mon, 15 Jun 2020 12:35:05 +0200 [thread overview]
Message-ID: <877dw8borq.fsf@belgarion.home> (raw)
In-Reply-To: <20200610172615.GD90634@mwanda> (Dan Carpenter's message of "Wed, 10 Jun 2020 20:26:15 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> It's not possible for "pcdev->mclk" to be zero because we check for
> that earlier and set it to 20000000 in that situation. If it were
> possible, that would be a problem because it could have lead to an Oops
> in the error handling when we call v4l2_clk_unregister(pcdev->mclk_clk);
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
prev parent reply other threads:[~2020-06-15 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 17:26 [PATCH] media: pxa_camera: remove an impossible condition Dan Carpenter
2020-06-15 10:35 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dw8borq.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=dan.carpenter@oracle.com \
--cc=hslester96@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox