* Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port [not found] ` <20230123073305.149940-11-lchen@ambarella.com> @ 2023-01-23 9:50 ` Greg Kroah-Hartman 2023-01-23 9:51 ` Greg Kroah-Hartman 1 sibling, 0 replies; 3+ messages in thread From: Greg Kroah-Hartman @ 2023-01-23 9:50 UTC (permalink / raw) To: Li Chen Cc: Jiri Slaby, Li Chen, Sumit Semwal, Christian König, open list, open list:SERIAL DRIVERS, moderated list:ARM/Ambarella SoC support, open list:DMA BUFFER SHARING FRAMEWORK, open list:DMA BUFFER SHARING FRAMEWORK, moderated list:DMA BUFFER SHARING FRAMEWORK On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote: > This driver add support for Ambarella's uart, which > can be used for console and etc. > > Signed-off-by: Li Chen <lchen@ambarella.com> > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730 Please always use scripts/checkpatch.pl so you don't get grumpy maintainers asking you why you didn't run scripts/checkpatch.pl :( ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port [not found] ` <20230123073305.149940-11-lchen@ambarella.com> 2023-01-23 9:50 ` [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port Greg Kroah-Hartman @ 2023-01-23 9:51 ` Greg Kroah-Hartman 2023-01-25 10:01 ` Li Chen 1 sibling, 1 reply; 3+ messages in thread From: Greg Kroah-Hartman @ 2023-01-23 9:51 UTC (permalink / raw) To: Li Chen Cc: Jiri Slaby, Li Chen, Sumit Semwal, Christian König, open list, open list:SERIAL DRIVERS, moderated list:ARM/Ambarella SoC support, open list:DMA BUFFER SHARING FRAMEWORK, open list:DMA BUFFER SHARING FRAMEWORK, moderated list:DMA BUFFER SHARING FRAMEWORK On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote: > This driver add support for Ambarella's uart, which > can be used for console and etc. > > Signed-off-by: Li Chen <lchen@ambarella.com> > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730 > --- > MAINTAINERS | 1 + > drivers/tty/serial/Kconfig | 16 + > drivers/tty/serial/Makefile | 1 + > drivers/tty/serial/ambarella_uart.c | 1581 +++++++++++++++++++++++++++ > drivers/tty/serial/ambarella_uart.h | 120 ++ Why do you need a .h file for a single .c file? They should all be in one file please. Also, no change-id, you know this... thanks, greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port 2023-01-23 9:51 ` Greg Kroah-Hartman @ 2023-01-25 10:01 ` Li Chen 0 siblings, 0 replies; 3+ messages in thread From: Li Chen @ 2023-01-25 10:01 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Li Chen, Jiri Slaby, Sumit Semwal, Christian König, open list, open list:SERIAL DRIVERS, moderated list:ARM/Ambarella SoC support, open list:DMA BUFFER SHARING FRAMEWORK, open list:DMA BUFFER SHARING FRAMEWORK, moderated list:DMA BUFFER SHARING FRAMEWORK On Mon, 23 Jan 2023 17:51:25 +0800, Hi Greg, Sorry for my late reply. Greg Kroah-Hartman wrote: > > On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote: > > This driver add support for Ambarella's uart, which > > can be used for console and etc. > > > > Signed-off-by: Li Chen <lchen@ambarella.com> > > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730 > > --- > > MAINTAINERS | 1 + > > drivers/tty/serial/Kconfig | 16 + > > drivers/tty/serial/Makefile | 1 + > > drivers/tty/serial/ambarella_uart.c | 1581 +++++++++++++++++++++++++++ > > drivers/tty/serial/ambarella_uart.h | 120 ++ > > Why do you need a .h file for a single .c file? They should all be in > one file please. Ok, I will combine them into single source file. > Also, no change-id, you know this... > > thanks, > > greg k-h Regards, Li ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-25 10:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230123073305.149940-1-lchen@ambarella.com>
[not found] ` <20230123073305.149940-11-lchen@ambarella.com>
2023-01-23 9:50 ` [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port Greg Kroah-Hartman
2023-01-23 9:51 ` Greg Kroah-Hartman
2023-01-25 10:01 ` Li Chen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox