From: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
To: Renjiang Han <renjiang.han@oss.qualcomm.com>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Alexandre Courbot <acourbot@chromium.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Tomasz Figa <tfiga@chromium.org>,
Hans Verkuil <hverkuil@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH 1/3] media: qcom: venus: drop extra padding in NV12 raw size calculation
Date: Mon, 6 Apr 2026 11:30:33 +0530 [thread overview]
Message-ID: <928b3c14-fd3a-73c1-5780-2b8302fccb7b@oss.qualcomm.com> (raw)
In-Reply-To: <20260331-fix_venus_bug_issue-v1-1-e4ae7a1d8db2@oss.qualcomm.com>
On 3/31/2026 10:07 AM, Renjiang Han wrote:
> get_framesize_raw_nv12() currently adds SZ_4K to the UV plane size and an
> additional SZ_8K to the total buffer size. This inflates the calculated
> sizeimage and leads userspace to over-allocate buffers without a clear
> requirement.
>
> Remove the extra SZ_4K/SZ_8K padding and compute the NV12 size as the sum
> of Y and UV planes, keeping the final ALIGN(size, SZ_4K) intact.
>
> Fixes: e1cb72de702ad ("media: venus: helpers: move frame size calculations on common place")
> Signed-off-by: Renjiang Han <renjiang.han@oss.qualcomm.com>
> ---
> drivers/media/platform/qcom/venus/helpers.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
> index 747c388fe25fa30770ac2e81d42f4daf83d74ddf..59eee3dd9e06c27165f29fc034d151eb13cd2349 100644
> --- a/drivers/media/platform/qcom/venus/helpers.c
> +++ b/drivers/media/platform/qcom/venus/helpers.c
> @@ -954,8 +954,8 @@ static u32 get_framesize_raw_nv12(u32 width, u32 height)
> uv_sclines = ALIGN(((height + 1) >> 1), 16);
>
> y_plane = y_stride * y_sclines;
> - uv_plane = uv_stride * uv_sclines + SZ_4K;
> - size = y_plane + uv_plane + SZ_8K;
> + uv_plane = uv_stride * uv_sclines;
> + size = y_plane + uv_plane;
>
> return ALIGN(size, SZ_4K);
> }
>
Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Thanks,
Dikshita
next prev parent reply other threads:[~2026-04-06 6:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 4:37 [PATCH 0/3] media: venus: fix NV12 buffer sizing and incorrect capability alignment Renjiang Han
2026-03-31 4:37 ` [PATCH 1/3] media: qcom: venus: drop extra padding in NV12 raw size calculation Renjiang Han
2026-04-06 6:00 ` Dikshita Agarwal [this message]
2026-03-31 4:37 ` [PATCH 2/3] media: qcom: venus: relax encoder frame/blur dimension steps on v4 Renjiang Han
2026-04-06 6:01 ` Dikshita Agarwal
2026-03-31 4:37 ` [PATCH 3/3] media: qcom: venus: relax encoder frame/blur step size on v6 Renjiang Han
2026-04-06 6:01 ` Dikshita Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=928b3c14-fd3a-73c1-5780-2b8302fccb7b@oss.qualcomm.com \
--to=dikshita.agarwal@oss.qualcomm.com \
--cc=acourbot@chromium.org \
--cc=bod@kernel.org \
--cc=hverkuil@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mchehab@kernel.org \
--cc=renjiang.han@oss.qualcomm.com \
--cc=stanimir.varbanov@linaro.org \
--cc=tfiga@chromium.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox