From: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
To: Renjiang Han <renjiang.han@oss.qualcomm.com>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Alexandre Courbot <acourbot@chromium.org>,
Tomasz Figa <tfiga@chromium.org>,
Hans Verkuil <hverkuil@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH 3/3] media: qcom: venus: relax encoder frame/blur step size on v6
Date: Mon, 6 Apr 2026 11:31:47 +0530 [thread overview]
Message-ID: <eb7c7137-8595-596d-bf21-b82397e43fb9@oss.qualcomm.com> (raw)
In-Reply-To: <20260331-fix_venus_bug_issue-v1-3-e4ae7a1d8db2@oss.qualcomm.com>
On 3/31/2026 10:07 AM, Renjiang Han wrote:
> Encoder HFI capabilities on v6 enforce a 16-pixel step for frame and blur
> dimensions, which does not reflect actual hardware requirements and can
> reject valid userspace configurations.
>
> Relax the step size to 1 while leaving min/max limits unchanged.
>
> Fixes: 869d77e706290 ("media: venus: hfi_plat_v6: Populate capabilities for v6")
> Signed-off-by: Renjiang Han <renjiang.han@oss.qualcomm.com>
> ---
> drivers/media/platform/qcom/venus/hfi_platform_v6.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_platform_v6.c b/drivers/media/platform/qcom/venus/hfi_platform_v6.c
> index d8568c08cc3612a0024d36f65c741151a23459c3..fb8d10ab34043ee676bd7adcf9420d4274ce9d78 100644
> --- a/drivers/media/platform/qcom/venus/hfi_platform_v6.c
> +++ b/drivers/media/platform/qcom/venus/hfi_platform_v6.c
> @@ -173,8 +173,8 @@ static const struct hfi_plat_caps caps[] = {
> .codec = HFI_VIDEO_CODEC_HEVC,
> .domain = VIDC_SESSION_TYPE_ENC,
> .cap_bufs_mode_dynamic = true,
> - .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 128, 8192, 16},
> - .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 128, 8192, 16},
> + .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 128, 8192, 1},
> + .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 128, 8192, 1},
> .caps[2] = {HFI_CAPABILITY_MBS_PER_FRAME, 64, 138240, 1},
> .caps[3] = {HFI_CAPABILITY_BITRATE, 1, 160000000, 1},
> .caps[4] = {HFI_CAPABILITY_SCALE_X, 8192, 65536, 1},
> @@ -195,8 +195,8 @@ static const struct hfi_plat_caps caps[] = {
> .caps[19] = {HFI_CAPABILITY_RATE_CONTROL_MODES, 0x1000001, 0x1000005, 1},
> .caps[20] = {HFI_CAPABILITY_COLOR_SPACE_CONVERSION, 0, 2, 1},
> .caps[21] = {HFI_CAPABILITY_ROTATION, 1, 4, 90},
> - .caps[22] = {HFI_CAPABILITY_BLUR_WIDTH, 96, 4096, 16},
> - .caps[23] = {HFI_CAPABILITY_BLUR_HEIGHT, 96, 4096, 16},
> + .caps[22] = {HFI_CAPABILITY_BLUR_WIDTH, 96, 4096, 1},
> + .caps[23] = {HFI_CAPABILITY_BLUR_HEIGHT, 96, 4096, 1},
> .num_caps = 24,
> .pl[0] = {HFI_HEVC_PROFILE_MAIN, HFI_HEVC_LEVEL_6 | HFI_HEVC_TIER_HIGH0},
> .pl[1] = {HFI_HEVC_PROFILE_MAIN10, HFI_HEVC_LEVEL_6 | HFI_HEVC_TIER_HIGH0},
> @@ -210,8 +210,8 @@ static const struct hfi_plat_caps caps[] = {
> .codec = HFI_VIDEO_CODEC_VP8,
> .domain = VIDC_SESSION_TYPE_ENC,
> .cap_bufs_mode_dynamic = true,
> - .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 128, 4096, 16},
> - .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 128, 4096, 16},
> + .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 128, 4096, 1},
> + .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 128, 4096, 1},
> .caps[2] = {HFI_CAPABILITY_MBS_PER_FRAME, 64, 36864, 1},
> .caps[3] = {HFI_CAPABILITY_BITRATE, 1, 74000000, 1},
> .caps[4] = {HFI_CAPABILITY_SCALE_X, 8192, 65536, 1},
> @@ -229,8 +229,8 @@ static const struct hfi_plat_caps caps[] = {
> .caps[16] = {HFI_CAPABILITY_P_FRAME_QP, 0, 127, 1},
> .caps[17] = {HFI_CAPABILITY_MAX_WORKMODES, 1, 2, 1},
> .caps[18] = {HFI_CAPABILITY_RATE_CONTROL_MODES, 0x1000001, 0x1000005, 1},
> - .caps[19] = {HFI_CAPABILITY_BLUR_WIDTH, 96, 4096, 16},
> - .caps[20] = {HFI_CAPABILITY_BLUR_HEIGHT, 96, 4096, 16},
> + .caps[19] = {HFI_CAPABILITY_BLUR_WIDTH, 96, 4096, 1},
> + .caps[20] = {HFI_CAPABILITY_BLUR_HEIGHT, 96, 4096, 1},
> .caps[21] = {HFI_CAPABILITY_COLOR_SPACE_CONVERSION, 0, 2, 1},
> .caps[22] = {HFI_CAPABILITY_ROTATION, 1, 4, 90},
> .num_caps = 23,
>
Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Thanks,
Dikshita
prev parent reply other threads:[~2026-04-06 6:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 4:37 [PATCH 0/3] media: venus: fix NV12 buffer sizing and incorrect capability alignment Renjiang Han
2026-03-31 4:37 ` [PATCH 1/3] media: qcom: venus: drop extra padding in NV12 raw size calculation Renjiang Han
2026-04-06 6:00 ` Dikshita Agarwal
2026-03-31 4:37 ` [PATCH 2/3] media: qcom: venus: relax encoder frame/blur dimension steps on v4 Renjiang Han
2026-04-06 6:01 ` Dikshita Agarwal
2026-03-31 4:37 ` [PATCH 3/3] media: qcom: venus: relax encoder frame/blur step size on v6 Renjiang Han
2026-04-06 6:01 ` Dikshita Agarwal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb7c7137-8595-596d-bf21-b82397e43fb9@oss.qualcomm.com \
--to=dikshita.agarwal@oss.qualcomm.com \
--cc=acourbot@chromium.org \
--cc=bod@kernel.org \
--cc=hverkuil@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mchehab@kernel.org \
--cc=renjiang.han@oss.qualcomm.com \
--cc=tfiga@chromium.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox