* [PATCH] media: i2c: ov02a10: fix an uninitialized return
@ 2020-12-07 13:00 Dan Carpenter
2020-12-07 13:14 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-12-07 13:00 UTC (permalink / raw)
To: Dongchun Zhu
Cc: Mauro Carvalho Chehab, Sakari Ailus, Andy Shevchenko, linux-media,
kernel-janitors
The "ret" variable isn't set on the no-op path where we are setting to
on/off and it's in the on or off state already.
Fixes: 91807efbe8ec ("media: i2c: add OV02A10 image sensor driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/media/i2c/ov02a10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c
index 391718136ade..cf40e207ea21 100644
--- a/drivers/media/i2c/ov02a10.c
+++ b/drivers/media/i2c/ov02a10.c
@@ -530,7 +530,7 @@ static int ov02a10_s_stream(struct v4l2_subdev *sd, int on)
{
struct ov02a10 *ov02a10 = to_ov02a10(sd);
struct i2c_client *client = v4l2_get_subdevdata(&ov02a10->subdev);
- int ret;
+ int ret = 0;
mutex_lock(&ov02a10->mutex);
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: i2c: ov02a10: fix an uninitialized return
2020-12-07 13:00 [PATCH] media: i2c: ov02a10: fix an uninitialized return Dan Carpenter
@ 2020-12-07 13:14 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2020-12-07 13:14 UTC (permalink / raw)
To: Dan Carpenter
Cc: Dongchun Zhu, Mauro Carvalho Chehab, Andy Shevchenko, linux-media,
kernel-janitors
Hi Dan,
On Mon, Dec 07, 2020 at 04:00:29PM +0300, Dan Carpenter wrote:
> The "ret" variable isn't set on the no-op path where we are setting to
> on/off and it's in the on or off state already.
>
> Fixes: 91807efbe8ec ("media: i2c: add OV02A10 image sensor driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for the patch.
This issue has been fixed by another patch here:
<URL:https://patchwork.linuxtv.org/project/linux-media/patch/20201204082037.1658297-1-arnd@kernel.org/>
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-07 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-07 13:00 [PATCH] media: i2c: ov02a10: fix an uninitialized return Dan Carpenter
2020-12-07 13:14 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox